From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Nick Piggin <npiggin@suse.de>, Andi Kleen <andi@firstfloor.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [rfc] x86: optimise page fault path a little
Date: Thu, 13 Nov 2008 09:35:36 +0100 [thread overview]
Message-ID: <20081113083536.GQ3810@one.firstfloor.org> (raw)
In-Reply-To: <20081113074109.GB1723@elte.hu>
> this flow could be cleaned up further:
>
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
>
> Any reason why that pattern shouldnt be changed to an appropriate goto
> bad_area? (probably the same goes for the nosemaphore error paths too)
The tail call is already effectively a goto.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-13 8:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 7:28 Nick Piggin
2008-11-13 7:41 ` Ingo Molnar
2008-11-13 7:50 ` Nick Piggin
2008-11-13 8:02 ` Ingo Molnar
2008-11-14 1:22 ` Nick Piggin
2008-11-13 16:06 ` Ingo Molnar
2008-11-14 1:16 ` Nick Piggin
2008-11-13 8:35 ` Andi Kleen [this message]
2008-11-13 16:00 ` Linus Torvalds
2008-11-14 1:58 ` Nick Piggin
2008-11-14 2:07 ` Linus Torvalds
2008-11-14 2:43 ` Nick Piggin
2008-11-14 3:18 ` Linus Torvalds
2008-11-14 3:30 ` Nick Piggin
2008-11-14 4:44 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113083536.GQ3810@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®