From: Nick Piggin <npiggin@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [rfc] x86: optimise page fault path a little
Date: Fri, 14 Nov 2008 03:43:47 +0100 [thread overview]
Message-ID: <20081114024347.GB24414@wotan.suse.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0811131803300.3468@nehalem.linux-foundation.org>
On Thu, Nov 13, 2008 at 06:07:45PM -0800, Linus Torvalds wrote:
>
>
> On Fri, 14 Nov 2008, Nick Piggin wrote:
> >
> > True, but is it any better to jam them all into a 300 line function
> > with gotos?
>
> That wasn't what I was saying.
>
> Theere are two "good" cases:
>
> - don't mess with things.
>
> This is good. Stability is good.
>
> - Clearly improve things.
>
> This is great.
>
> And I'll happily do either of the above.
>
> Your patch had some improvement, but it had some clear not-so-improved
> parts. That makes it INFERIOR to just leaving things well alone.
>
> The thing is, I'm not very much interested in just a micro-optimization
> that seems to be all about just gcc code generation. Long-term, that's
> just bad.
>
> But if it's a clear and undeniable _cleanup_, then long-term, it's
> actually a win. If it also happens to fix some gcc stack allocation issues
> etc, then that is just gravy.
>
> See my point? Cleanup is good. But it had better _be_ a cleanup. Random
> micro-optimization is not so good, especially not if it them makes the
> code do things that good code simply shouldn't be doing.
It's not a cleanup, it's an optimisation. I just didn't happen to think
it particularly makes the code *less* clean, unlike you. But I'd *never*
try to merge pointless churn like this as a cleanup because I didn't
think the old code was too bad either.
No, it's purely an optimisation. And it is using knowlege of how gcc
generates code to some extent. But adding branch annotations and
out of lining things isn't really something gcc will be able to
do on its own (it could _guess_, or use PGO, and do better register
allocation, I guess).
Anyway, it saves 300 bytes of stack footprint and seems to save a
couple of lines of icache footprint by packing the fastpaths better.
I don't exactly know what you mean by random micro-optimization. It is
what it is. I like counting cachelines and branches and I thought you
did as well.
next prev parent reply other threads:[~2008-11-14 2:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 7:28 Nick Piggin
2008-11-13 7:41 ` Ingo Molnar
2008-11-13 7:50 ` Nick Piggin
2008-11-13 8:02 ` Ingo Molnar
2008-11-14 1:22 ` Nick Piggin
2008-11-13 16:06 ` Ingo Molnar
2008-11-14 1:16 ` Nick Piggin
2008-11-13 8:35 ` Andi Kleen
2008-11-13 16:00 ` Linus Torvalds
2008-11-14 1:58 ` Nick Piggin
2008-11-14 2:07 ` Linus Torvalds
2008-11-14 2:43 ` Nick Piggin [this message]
2008-11-14 3:18 ` Linus Torvalds
2008-11-14 3:30 ` Nick Piggin
2008-11-14 4:44 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081114024347.GB24414@wotan.suse.de \
--to=npiggin@suse.de \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®