Re: [PATCH] x86 - Make CONFIG_OLPC dependent on CONFIG_MGEODE_LX

[Pavel Machek <pavel@suse.cz>]

> > > > > but what we really need to
> > > > > do is to make geode_gpio* defined even when we're not specifically
> > > > > building with MGEODE_LX.  I'm not sure how best to do that, but the
> > > > > answer probably includes using the generic x86 gpio api.
> > > > 
> > > > This probably needs to be done as a precondition for getting the alsa
> > > > changes merged or the alsa changes need to have the bits which depend on
> > > > geode_gpio ripped out until it can be done.
> > > 
> > > Then let's stop inclusion of asm/geode.h from asm/olpc.h at first.
> > > Any driver codes including asm/geode.h can be broken potentially
> > > without a proper dependency.
> > 
> > Yes, but having a driver dependent on building for a specific x86
> > variant is quite wrong. 
> 
> Not so.  Many drivers are very hardware-specific, and they are (must
> be) based on certain architectures and platforms.  Look at a bunch of
> drivers based on ARM-variants, for example.

No.

It should be possible to compile kernel for i386 and have it run on
OLPC. This breaks it.

CPU type is optimalization option, only.

> IMO, the basic problem is rather that the platform and the CPU
> selection is mixed up.  The geode GPIO stuff shouldn't belong to CPU
> selection.

ACK... and suggested patch makes it worse.

There should be option 'support OLPC' somewhere, and that should
enable the gpio bits. Alsa driver should depend on that one.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html