mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Nelson <markn@au1.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org,
	David Brownell <dbrownell@users.sourceforge.net>
Subject: commit "genirq: record trigger type" and powerpc
Date: Thu, 13 Nov 2008 17:30:11 +1100	[thread overview]
Message-ID: <200811131730.11506.markn@au1.ibm.com> (raw)

Hi Ingo,

I noticed that after commit 0c5d1eb77a8be917b638344a22afe1398236482b
(genirq: record trigger type), several of our powerpc platforms now
spew out warnings about "No set_type function for IRQ..." (in
particular our Cell blades). This is because in our generic platform
code we call set_irq_type() with information from the device tree
when we establish the interrupt mappings; but we do this regardless
of whether the PIC can actually set a type (it might irrelevant
because the type is essentially hardcoded or as in the case for Cell
the interrupts are just messages being past around that have no real
concept of type, or we could even be dealing with a virtual PIC as
on the PS3).

So, would it be possible to turn the:

	pr_warning("No set_type function... 

into a pr_debug() in kernel/irq/manage.c so when our users upgrade
to newer kernels they don't get scared by a whole bunch of new
warnings?

Many thanks!

Mark

             reply	other threads:[~2008-11-13  6:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13  6:30 Mark Nelson [this message]
2008-11-13  7:43 ` Ingo Molnar
2008-11-13 10:37   ` [PATCH] genirq: __irq_set_trigger: change pr_warning to pr_debug Mark Nelson
2008-11-13 11:11     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811131730.11506.markn@au1.ibm.com \
    --to=markn@au1.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®