From: Mark Nelson <markn@au1.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>
Subject: [PATCH] genirq: __irq_set_trigger: change pr_warning to pr_debug
Date: Thu, 13 Nov 2008 21:37:41 +1100 [thread overview]
Message-ID: <200811132137.41863.markn@au1.ibm.com> (raw)
In-Reply-To: <20081113074300.GC1723@elte.hu>
Commit 0c5d1eb77a8be917b638344a22afe1398236482b (genirq: record trigger
type) caused powerpc platforms that had no set_type() function in their
struct irq_chip to spew out warnings about "No set_type function for
IRQ...". This warning isn't necessarily justified though because the
generic powerpc platform code calls set_irq_type() (which in turn calls
__irq_set_trigger) with information from the device tree to establish
the interrupt mappings, regardless of whether the PIC can actually set
a type.
A platform's irq_chip might not have a set_type function for a variety
of reasons, for example: the platform may have the type essentially
hard-coded, or as in the case for Cell interrupts are just messages
past around that have no real concept of type, or the platform
could even have a virtual PIC as on the PS3.
Signed-off-by: Mark Nelson <markn@au1.ibm.com>
---
Thanks Ingo! Much appreciated
kernel/irq/manage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: upstream/kernel/irq/manage.c
===================================================================
--- upstream.orig/kernel/irq/manage.c
+++ upstream/kernel/irq/manage.c
@@ -327,7 +327,7 @@ int __irq_set_trigger(struct irq_desc *d
* IRQF_TRIGGER_* but the PIC does not support multiple
* flow-types?
*/
- pr_warning("No set_type function for IRQ %d (%s)\n", irq,
+ pr_debug("No set_type function for IRQ %d (%s)\n", irq,
chip ? (chip->name ? : "unknown") : "unknown");
return 0;
}
next prev parent reply other threads:[~2008-11-13 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 6:30 commit "genirq: record trigger type" and powerpc Mark Nelson
2008-11-13 7:43 ` Ingo Molnar
2008-11-13 10:37 ` Mark Nelson [this message]
2008-11-13 11:11 ` [PATCH] genirq: __irq_set_trigger: change pr_warning to pr_debug Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811132137.41863.markn@au1.ibm.com \
--to=markn@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®