From: Andre Noll <maan@systemlinux.org>
To: Justin Piszcz <jpiszcz@lucidpixels.com>
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Subject: Re: typo in raid[456] kernel code/no change based on type?
Date: Fri, 14 Nov 2008 18:53:42 +0100 [thread overview]
Message-ID: <20081114175342.GK17300@skl-net.de> (raw)
In-Reply-To: <alpine.DEB.1.10.0811140743050.20662@p34.internal.lan>
[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]
On 08:05, Justin Piszcz wrote:
> [ patch ]
>
> # patch -p1 < /home/jpiszcz/patch
> patching file drivers/md/raid5.c
> Hunk #1 succeeded at 4302 (offset -41 lines).
>
> Ok, fixed some of them but not all:
Sure. The main part of the raid 4/5/6 code is in the single file raid5.c
which frequently calls all its supported raid levels "raid5". The patch
I've posted only cleans up one function in that file.
> Here is the current output that still contains 'raid5':
>
> $ dmesg | grep -i raid5
> [ 19.881548] md: raid5 personality registered for level 5
> [ 21.408354] raid5: device sdl1 operational as raid disk 8
> [ 21.410583] raid5: device sdk1 operational as raid disk 1
> [ 21.412789] raid5: device sdj1 operational as raid disk 5
> [ 21.414994] raid5: device sdi1 operational as raid disk 9
> [ 21.417217] raid5: device sdh1 operational as raid disk 7
> [ 21.419420] raid5: device sdg1 operational as raid disk 6
> [ 21.421622] raid5: device sdf1 operational as raid disk 3
> [ 21.423810] raid5: device sde1 operational as raid disk 2
> [ 21.425970] raid5: device sdd1 operational as raid disk 0
> [ 21.428090] raid5: device sdc1 operational as raid disk 4
> [ 21.430884] raid5: allocated 10568kB for md3
> [ 21.433023] raid5: raid level 6 set md3 active with 10 out of 10
> devices, algorithm 2
Of course these can also be fixed easily. But let's first see whether
Neil wants to take such trivial stuff ATM.
Andre
--
The only person who always got his work done by Friday was Robinson Crusoe
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2008-11-14 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 23:58 Justin Piszcz
2008-11-12 23:58 ` Justin Piszcz
2008-11-14 12:19 ` Andre Noll
2008-11-14 13:05 ` Justin Piszcz
2008-11-14 17:53 ` Andre Noll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081114175342.GK17300@skl-net.de \
--to=maan@systemlinux.org \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®