From: Andi Kleen <andi@firstfloor.org>
To: mingo@elte.hu, peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH REPOST] [3/3] SCHED: don't inline idle_balance into schedule()
Date: Sat, 15 Nov 2008 14:38:02 +0100 (CET) [thread overview]
Message-ID: <20081115133802.5DA4C3E661B@basil.firstfloor.org> (raw)
In-Reply-To: <20081115237.317953894@firstfloor.org>
This function is not called under load, so it makes sense to out of line
it to get better register allocation in schedule() and make the assembler
easier to read.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
kernel/sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.28-rc4-test/kernel/sched.c
===================================================================
--- linux-2.6.28-rc4-test.orig/kernel/sched.c 2008-11-12 12:52:52.000000000 +0100
+++ linux-2.6.28-rc4-test/kernel/sched.c 2008-11-12 13:07:53.000000000 +0100
@@ -3696,7 +3696,7 @@
* idle_balance is called by schedule() if this_cpu is about to become
* idle. Attempts to pull tasks from other CPUs.
*/
-static void idle_balance(int this_cpu, struct rq *this_rq)
+static void noinline idle_balance(int this_cpu, struct rq *this_rq)
{
struct sched_domain *sd;
int pulled_task = -1;
prev parent reply other threads:[~2008-11-15 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 13:37 [PATCH REPOST] [0/3] SCHED: Trivial scheduler fixes Andi Kleen
2008-11-15 13:38 ` [PATCH REPOST] [1/3] SCHED: cache task_hot result Andi Kleen
2008-11-15 13:38 ` [PATCH REPOST] [2/3] SCHED: Mark all frequently used sysctls __read_mostly Andi Kleen
2008-11-15 13:38 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081115133802.5DA4C3E661B@basil.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome