mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bernhard Walle <bwalle@suse.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, crash-utility@redhat.com,
	Bernhard Walle <bwalle@suse.de>
Subject: Re: Turn CONFIG_STRICT_DEVMEM in sysctl dev.mem.restricted
Date: Sun, 16 Nov 2008 15:07:56 +0000	[thread overview]
Message-ID: <20081116150756.3cece2de@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1226846868-9595-1-git-send-email-bwalle@suse.de>

> The protection in the general case and the ability to do live debugging.

What protection. You've completely failed to explain or provide a single
example of any protection provided by the STRICT_DEVMEM code.

> only a half of the story. The truth is that at least RHEL has /dev/crash
> exactly to circumvent that /dev/mem restriction. Don't tell me that this
> is better than having that sysctl entry. ;-)

Which nicely illustrates what a waste of time the whole thing is.

Please do the decent thing and just turn the crap concerned off. The fact
other vendors get it wrong doesn't mean you need to copy. Even better
submit a patch to remove this rubbish from the kernel completely.

Your patch is still adding bells and whistles to a useless turd. In fact
this patch is worse. Without this patch the turd can be disabled and left
out, with your patch everyone now has to compile in said turd pile.

NAK this changeset.

Alan

  parent reply	other threads:[~2008-11-16 15:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-16 14:47 Bernhard Walle
2008-11-16 14:47 ` [PATCH 1/3] Unify devmem_is_allowed across architectures Bernhard Walle
2008-11-16 14:47 ` [PATCH 2/3] Add dev.mem.restricted sysctl Bernhard Walle
2008-11-16 15:07   ` Willy Tarreau
2008-11-16 14:47 ` [PATCH 3/3] Remove CONFIG_STRICT_DEVMEM Bernhard Walle
2008-11-16 15:09   ` Alan Cox
2008-11-16 15:21     ` Bernhard Walle
2008-11-16 15:46       ` Alan Cox
2008-11-17 13:57     ` David Howells
2008-11-16 15:07 ` Alan Cox [this message]
2008-11-16 15:20   ` Turn CONFIG_STRICT_DEVMEM in sysctl dev.mem.restricted Bernhard Walle
2008-11-16 15:45     ` Alan Cox
2008-11-16 16:03       ` Arjan van de Ven
2008-11-16 16:09         ` Alan Cox
2008-11-16 16:19         ` Bernhard Walle
2008-11-16 16:11       ` Bernhard Walle
2008-11-16 17:03         ` Alan Cox
2008-11-16 15:39 ` Arjan van de Ven
2008-11-16 15:56   ` Bernhard Walle
2008-11-16 16:06     ` Arjan van de Ven
2008-11-16 20:32   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081116150756.3cece2de@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=bwalle@suse.de \
    --cc=crash-utility@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®