From: Mark Brown <broonie@sirena.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: rpurdie@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Add WM8350 LED driver
Date: Mon, 17 Nov 2008 11:57:09 +0000 [thread overview]
Message-ID: <20081117115709.GF1559@sirena.org.uk> (raw)
In-Reply-To: <20081114151908.0af38e4c.akpm@linux-foundation.org>
On Fri, Nov 14, 2008 at 03:19:08PM -0800, Andrew Morton wrote:
> > + led_classdev_unregister(&led->cdev);
> > + schedule_work(&led->work);
> > + flush_scheduled_work();
> The schedule_work() is unexpected and I can't immediately see why it's
> here. If it is indeed correct, I'd suggest the addition of a comment.
Me either, I'll remove it and fix the other things you raised too.
Thanks.
next prev parent reply other threads:[~2008-11-17 11:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 12:39 Mark Brown
2008-11-13 14:57 ` [PATCH] leds: Fix locking for WM8350 Mark Brown
2008-11-15 17:31 ` Pavel Machek
2008-11-15 17:50 ` Mark Brown
2008-11-15 18:51 ` Pavel Machek
2008-11-15 19:14 ` Mark Brown
2008-11-17 15:33 ` Richard Purdie
2008-11-17 23:05 ` Mark Brown
2008-11-18 8:33 ` Pavel Machek
2008-11-14 23:19 ` [PATCH] leds: Add WM8350 LED driver Andrew Morton
2008-11-17 11:57 ` Mark Brown [this message]
2008-11-15 17:29 ` Pavel Machek
2008-11-15 17:43 ` Mark Brown
2008-11-17 14:52 Mark Brown
2008-11-17 15:25 ` Frederik Deweerdt
2008-11-17 15:29 ` Mark Brown
2008-11-26 13:53 Mark Brown
2008-11-26 17:39 ` Sven Wegener
2008-11-26 18:17 ` Mark Brown
2008-11-26 18:26 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117115709.GF1559@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome