From: Mark Brown <broonie@sirena.org.uk>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: Pavel Machek <pavel@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Fix locking for WM8350
Date: Mon, 17 Nov 2008 23:05:24 +0000 [thread overview]
Message-ID: <20081117230522.GA29916@sirena.org.uk> (raw)
In-Reply-To: <1226935995.17109.22.camel@ted>
On Mon, Nov 17, 2008 at 03:33:15PM +0000, Richard Purdie wrote:
> I've not looked in detail at the code but it looks like a maximum of a
> 32 bit value where you don't actually care which write succeeds as long
> as it takes one of the values written? I don't see why that particular
Pretty much (it's an enum led_brightness) - it's just a standard LED
that can't be written without taking interrupts along the lines of the
GPIO LED driver.
> variable needs any locking or to be atomic?
I'd certainly be surprised if it were an issue in any practical system.
next prev parent reply other threads:[~2008-11-17 23:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 12:39 [PATCH] leds: Add WM8350 LED driver Mark Brown
2008-11-13 14:57 ` [PATCH] leds: Fix locking for WM8350 Mark Brown
2008-11-15 17:31 ` Pavel Machek
2008-11-15 17:50 ` Mark Brown
2008-11-15 18:51 ` Pavel Machek
2008-11-15 19:14 ` Mark Brown
2008-11-17 15:33 ` Richard Purdie
2008-11-17 23:05 ` Mark Brown [this message]
2008-11-18 8:33 ` Pavel Machek
2008-11-14 23:19 ` [PATCH] leds: Add WM8350 LED driver Andrew Morton
2008-11-17 11:57 ` Mark Brown
2008-11-15 17:29 ` Pavel Machek
2008-11-15 17:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117230522.GA29916@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome