[PATCH] Deal with the warning from dmi_low_memory_corruption() being unused

[PATCH] Deal with the warning from dmi_low_memory_corruption() being unused

[David Howells]

Deal with the warning from dmi_low_memory_corruption() being unused when
CONFIG_X86_RESERVE_LOW_64K is not set:

arch/x86/kernel/setup.c:742: warning: 'dmi_low_memory_corruption' defined but not used

This was introduced by fc38151947477596aa27df6c4306ad6008dc6711.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 arch/x86/kernel/setup.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 0fa6790..c35ec3f 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -738,6 +738,7 @@ void start_periodic_check_for_corruption(void)
 }
 #endif
 
+#ifdef CONFIG_X86_RESERVE_LOW_64K
 static int __init dmi_low_memory_corruption(const struct dmi_system_id *d)
 {
 	printk(KERN_NOTICE
@@ -749,6 +750,7 @@ static int __init dmi_low_memory_corruption(const struct dmi_system_id *d)
 
 	return 0;
 }
+#endif
 
 /* List of systems that have known low memory corruption BIOS problems */
 static struct dmi_system_id __initdata bad_bios_dmi_table[] = {

Re: [PATCH] Deal with the warning from dmi_low_memory_corruption() being unused

[Ingo Molnar]

* David Howells <dhowells@redhat.com> wrote:

> Deal with the warning from dmi_low_memory_corruption() being unused 
> when CONFIG_X86_RESERVE_LOW_64K is not set:
> 
> arch/x86/kernel/setup.c:742: warning: 'dmi_low_memory_corruption' defined but not used
> 
> This was introduced by fc38151947477596aa27df6c4306ad6008dc6711.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
> 
>  arch/x86/kernel/setup.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

thx - already fixed via the patch below.

	Ingo

------------>
>From faad95db248fffe94b691a9c8f9cd0193584633a Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Fri, 17 Oct 2008 12:00:38 +0200
Subject: [PATCH] fix warning in arch/x86/kernel/setup.c
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

fix this warning:

  arch/x86/kernel/setup.c:736: warning: ‘dmi_low_memory_corruption’ defined but not used

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/setup.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 0fa6790..c35ec3f 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -738,6 +738,7 @@ void start_periodic_check_for_corruption(void)
 }
 #endif
 
+#ifdef CONFIG_X86_RESERVE_LOW_64K
 static int __init dmi_low_memory_corruption(const struct dmi_system_id *d)
 {
 	printk(KERN_NOTICE
@@ -749,6 +750,7 @@ static int __init dmi_low_memory_corruption(const struct dmi_system_id *d)
 
 	return 0;
 }
+#endif
 
 /* List of systems that have known low memory corruption BIOS problems */
 static struct dmi_system_id __initdata bad_bios_dmi_table[] = {