* [PATCH] x86: vmware - fix sparse warnings
@ 2008-11-21 22:17 Hannes Eder
2008-11-23 10:02 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2008-11-21 22:17 UTC (permalink / raw)
To: Alok N Kataria, Dan Hecht, linux-kernel, kernel-janitors
Fix the following sparse warnings:
arch/x86/kernel/cpu/vmware.c:69:5: warning: symbol 'vmware_platform'
was not declared. Should it be static?
arch/x86/kernel/cpu/vmware.c:89:15: warning: symbol
'vmware_get_tsc_khz' was not declared. Should it be static?
arch/x86/kernel/cpu/vmware.c:107:16: warning: symbol
'vmware_set_feature_bits' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
arch/x86/kernel/cpu/vmware.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c
index c034bda..284c399 100644
--- a/arch/x86/kernel/cpu/vmware.c
+++ b/arch/x86/kernel/cpu/vmware.c
@@ -23,6 +23,7 @@
#include <linux/dmi.h>
#include <asm/div64.h>
+#include <asm/vmware.h>
#define CPUID_VMWARE_INFO_LEAF 0x40000000
#define VMWARE_HYPERVISOR_MAGIC 0x564D5868
--
1.5.6.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: vmware - fix sparse warnings
2008-11-21 22:17 [PATCH] x86: vmware - fix sparse warnings Hannes Eder
@ 2008-11-23 10:02 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-23 10:02 UTC (permalink / raw)
To: Hannes Eder
Cc: Alok N Kataria, Dan Hecht, linux-kernel, kernel-janitors, H. Peter Anvin
* Hannes Eder <hannes@hanneseder.net> wrote:
> Fix the following sparse warnings:
>
> arch/x86/kernel/cpu/vmware.c:69:5: warning: symbol 'vmware_platform'
> was not declared. Should it be static?
> arch/x86/kernel/cpu/vmware.c:89:15: warning: symbol
> 'vmware_get_tsc_khz' was not declared. Should it be static?
> arch/x86/kernel/cpu/vmware.c:107:16: warning: symbol
> 'vmware_set_feature_bits' was not declared. Should it be static?
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
> arch/x86/kernel/cpu/vmware.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
applied to tip/x86/detect-hyper, thanks Hannes!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-23 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-21 22:17 [PATCH] x86: vmware - fix sparse warnings Hannes Eder
2008-11-23 10:02 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®