* [PATCH] x86: HPET: fix sparse warning
@ 2008-11-23 19:19 Hannes Eder
2008-11-23 19:23 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2008-11-23 19:19 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, linux-kernel, kernel-janitors
Fix this sparse warning:
arch/x86/kernel/hpet.c:36:18: warning: symbol 'hpet_num_timers' was
not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
arch/x86/kernel/hpet.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index 067d8de..15fcaac 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -33,7 +33,7 @@
* HPET address is set in acpi/boot.c, when an ACPI entry exists
*/
unsigned long hpet_address;
-unsigned long hpet_num_timers;
+static unsigned long hpet_num_timers;
static void __iomem *hpet_virt_address;
struct hpet_dev {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] x86: HPET: fix sparse warning
2008-11-23 19:19 [PATCH] x86: HPET: fix sparse warning Hannes Eder
@ 2008-11-23 19:23 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-23 19:23 UTC (permalink / raw)
To: Hannes Eder; +Cc: Thomas Gleixner, linux-kernel, kernel-janitors
* Hannes Eder <hannes@hanneseder.net> wrote:
> Fix this sparse warning:
>
> arch/x86/kernel/hpet.c:36:18: warning: symbol 'hpet_num_timers' was
> not declared. Should it be static?
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
> arch/x86/kernel/hpet.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied to tip/x86/sparse-fixes, thanks!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-23 19:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-23 19:19 [PATCH] x86: HPET: fix sparse warning Hannes Eder
2008-11-23 19:23 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®