mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Paalanen <pq@iki.fi>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	fweisbec@gmail.com
Subject: Re: [PATCH 1/2] mmiotrace: fix buffer overrun detection
Date: Sun, 23 Nov 2008 20:34:13 +0100	[thread overview]
Message-ID: <20081123193413.GB2794@elte.hu> (raw)
In-Reply-To: <20081123212430.4f6700e9@daedalus.pq.iki.fi>


* Pekka Paalanen <pq@iki.fi> wrote:

> From d5d72f3515ba3abffa317b985d7597718a024841 Mon Sep 17 00:00:00 2001
> From: Pekka Paalanen <pq@iki.fi>
> Date: Sun, 23 Nov 2008 19:18:18 +0200
> Subject: [PATCH] mmiotrace: fix buffer overrun detection
> 
> When ftrace framework moved to use the ring buffer facility, the buffer
> overrun detection was broken after 2.6.27 by commit
> 
> commit 3928a8a2d98081d1bc3c0a84a2d70e29b90ecf1c
> Author: Steven Rostedt <rostedt@goodmis.org>
> Date:   Mon Sep 29 23:02:41 2008 -0400
> 
>     ftrace: make work with new ring buffer
> 
>     This patch ports ftrace over to the new ring buffer.
> 
> The detection is now fixed by using the ring buffer API.
> 
> When mmiotrace detects a buffer overrun, it will report the number of
> lost events. People reading an mmiotrace log must know if something was
> missed, otherwise the data may not make sense.
> 
> Signed-off-by: Pekka Paalanen <pq@iki.fi>
> ---
> 
> Ingo, could these two patches still make it into .28?

Sure - applied them to tip/tracing/urgent:

  fb91ee6: tracing, doc: update mmiotrace documentation
  7ee1768: x86, mmiotrace: fix buffer overrun detection

Does this make mmiotrace fully functional in .28 ?

	Ingo

  reply	other threads:[~2008-11-23 19:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-23 13:41 Mmiotrace regression in 2.6.28-rc6 Pekka Paalanen
2008-11-23 14:03 ` Ingo Molnar
2008-11-23 16:35 ` Steven Rostedt
2008-11-23 19:24   ` [PATCH 1/2] mmiotrace: fix buffer overrun detection Pekka Paalanen
2008-11-23 19:34     ` Ingo Molnar [this message]
2008-11-23 19:59       ` Pekka Paalanen
2008-11-24 20:18       ` Pekka Paalanen
2008-11-24 20:30         ` Frédéric Weisbecker
2008-11-24 21:27           ` Pekka Paalanen
2008-11-25 11:55             ` Frédéric Weisbecker
2008-11-25 11:59               ` Frédéric Weisbecker
2008-11-25 17:13                 ` Pekka Paalanen
2008-11-23 19:24   ` [PATCH 2/2] doc: update mmiotrace documentation Pekka Paalanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081123193413.GB2794@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pq@iki.fi \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®