From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Pekka Paalanen" <pq@iki.fi>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Steven Rostedt" <rostedt@goodmis.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mmiotrace: fix buffer overrun detection
Date: Tue, 25 Nov 2008 12:59:22 +0100 [thread overview]
Message-ID: <c62985530811250359s42f1eb72kb65a5ac1a510d0d1@mail.gmail.com> (raw)
In-Reply-To: <c62985530811250355r6e1510fdv1a63ef89e6c06c94@mail.gmail.com>
2008/11/25 Frédéric Weisbecker <fweisbec@gmail.com>:
> Perhaps that:
>
> int trace_vprintk(unsigned long ip, const char *fmt, va_list args)
> {
> ......
> if (tracing_disabled)
> return 0;
Since this is the return value for tracing_mark_write(), it may better
return an error to avoid a spin when tracing
is disabled. -ENODEV I guess, or -EBUSY
The strange thing is that tracing_open_generic() shoud have return
-ENODEV in this case during the opening of trace_mark.
next prev parent reply other threads:[~2008-11-25 11:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 13:41 Mmiotrace regression in 2.6.28-rc6 Pekka Paalanen
2008-11-23 14:03 ` Ingo Molnar
2008-11-23 16:35 ` Steven Rostedt
2008-11-23 19:24 ` [PATCH 1/2] mmiotrace: fix buffer overrun detection Pekka Paalanen
2008-11-23 19:34 ` Ingo Molnar
2008-11-23 19:59 ` Pekka Paalanen
2008-11-24 20:18 ` Pekka Paalanen
2008-11-24 20:30 ` Frédéric Weisbecker
2008-11-24 21:27 ` Pekka Paalanen
2008-11-25 11:55 ` Frédéric Weisbecker
2008-11-25 11:59 ` Frédéric Weisbecker [this message]
2008-11-25 17:13 ` Pekka Paalanen
2008-11-23 19:24 ` [PATCH 2/2] doc: update mmiotrace documentation Pekka Paalanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62985530811250359s42f1eb72kb65a5ac1a510d0d1@mail.gmail.com \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pq@iki.fi \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®