* [PATCH] tokenring/3c359.c: Prevent possible mem leak when open failed
@ 2008-11-23 20:44 Jirka Pirko
2008-11-24 22:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jirka Pirko @ 2008-11-23 20:44 UTC (permalink / raw)
To: linux-kernel; +Cc: jgarzik, netdev, davem
Freeing previously allocated buffers in case of error.
Signed-off-by: Jirka Pirko <jirka@pirko.cz>
---
drivers/net/tokenring/3c359.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c
index 46fb308..4bb9ca8 100644
--- a/drivers/net/tokenring/3c359.c
+++ b/drivers/net/tokenring/3c359.c
@@ -669,6 +669,8 @@ static int xl_open(struct net_device *dev)
if (i==0) {
printk(KERN_WARNING "%s: Not enough memory to allocate rx buffers. Adapter disabled \n",dev->name) ;
free_irq(dev->irq,dev) ;
+ kfree(xl_priv->xl_tx_ring);
+ kfree(xl_priv->xl_rx_ring);
return -EIO ;
}
--
1.5.4.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tokenring/3c359.c: Prevent possible mem leak when open failed
2008-11-23 20:44 [PATCH] tokenring/3c359.c: Prevent possible mem leak when open failed Jirka Pirko
@ 2008-11-24 22:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-11-24 22:49 UTC (permalink / raw)
To: jirka; +Cc: linux-kernel, jgarzik, netdev
From: Jirka Pirko <jirka@pirko.cz>
Date: Sun, 23 Nov 2008 21:44:10 +0100
> Freeing previously allocated buffers in case of error.
>
> Signed-off-by: Jirka Pirko <jirka@pirko.cz>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-24 22:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-23 20:44 [PATCH] tokenring/3c359.c: Prevent possible mem leak when open failed Jirka Pirko
2008-11-24 22:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®