From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Shane McDonald <mcdonald.shane@gmail.com>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Resurrect IT8172 IDE controller driver
Date: Mon, 24 Nov 2008 09:55:10 +0000 [thread overview]
Message-ID: <20081124095510.31cc990f@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <E1L4UpB-0007ro-1g@localhost>
> This patch resurrects the IT8172 IDE controller code. I began with
> the 2.6.18 version of the it8172.c file, and have moved it forward so
This appears to be a PIIX clone, is it different enough to need its own
driver ?
> +static unsigned int __devinit init_chipset_it8172(struct pci_dev *dev)
> +{
> + unsigned char progif;
> +
> + /*
> + * Place both IDE interfaces into PCI "native" mode
> + */
> + pci_read_config_byte(dev, PCI_CLASS_PROG, &progif);
> + pci_write_config_byte(dev, PCI_CLASS_PROG, progif | 0x05);
> +
> + return dev->irq;
> +}
NAK. You can't do this here any more. The PCI code now understands
'legacy' PCI IDE header types and resources so you must fix up the
resources as a PCI quirk early on in boot or you will leave bogus
resource assignments around.
Alan
next prev parent reply other threads:[~2008-11-24 9:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 6:21 Shane McDonald
2008-11-24 9:55 ` Alan Cox [this message]
2008-11-24 10:02 ` Sergei Shtylyov
2008-11-24 10:33 ` Sergei Shtylyov
2008-11-24 12:12 ` Sergei Shtylyov
2008-11-24 12:32 ` Alan Cox
2008-11-24 13:38 ` Sergei Shtylyov
2008-12-04 3:08 ` Shane McDonald
2008-12-04 16:10 ` Sergei Shtylyov
2008-12-04 2:39 ` Shane McDonald
2008-12-04 10:07 ` Alan Cox
2008-12-04 14:01 ` Shane McDonald
2008-12-04 14:07 ` Alan Cox
2008-12-04 19:37 ` Bartlomiej Zolnierkiewicz
2008-12-04 16:17 ` Sergei Shtylyov
2008-12-08 12:02 ` Sergei Shtylyov
2008-12-22 7:50 ` Shane McDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124095510.31cc990f@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcdonald.shane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®