From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Shane McDonald" <mcdonald.shane@gmail.com>
Cc: "Sergei Shtylyov" <sshtylyov@ru.mvista.com>,
bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Resurrect IT8172 IDE controller driver
Date: Thu, 4 Dec 2008 10:07:17 +0000 [thread overview]
Message-ID: <20081204100717.32819f1b@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <b2b2f2320812031839q43eb6102jbae0fbddd9a1cf75@mail.gmail.com>
> I am not sure how to determine if IORDY sampling is supported by a
> drive. If I'm reading the code correctly, other drivers only check
> that the PIO mode is > 2 (not > 1 as in my driver) -- that seems to be
> the case for at least piix.c, siimage.c, and it8213.c.
Old IDE is wrong on this and in fact unless it has changed recently
simply can't cope with and doesn't provide functions for it. A libata
driver can use the libata helpers but those also rely on the core ata
code doing certain things so if you cut and paste it over you might have
to make other old IDE changes in parallel.
next prev parent reply other threads:[~2008-12-04 10:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 6:21 Shane McDonald
2008-11-24 9:55 ` Alan Cox
2008-11-24 10:02 ` Sergei Shtylyov
2008-11-24 10:33 ` Sergei Shtylyov
2008-11-24 12:12 ` Sergei Shtylyov
2008-11-24 12:32 ` Alan Cox
2008-11-24 13:38 ` Sergei Shtylyov
2008-12-04 3:08 ` Shane McDonald
2008-12-04 16:10 ` Sergei Shtylyov
2008-12-04 2:39 ` Shane McDonald
2008-12-04 10:07 ` Alan Cox [this message]
2008-12-04 14:01 ` Shane McDonald
2008-12-04 14:07 ` Alan Cox
2008-12-04 19:37 ` Bartlomiej Zolnierkiewicz
2008-12-04 16:17 ` Sergei Shtylyov
2008-12-08 12:02 ` Sergei Shtylyov
2008-12-22 7:50 ` Shane McDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204100717.32819f1b@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcdonald.shane@gmail.com \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®