From: Pierre Ossman <drzeus@drzeus.cx>
To: Philip Langdale <philipl@overt.org>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
sdhci-devel@list.drzeus.cx, Frank Seidel <fseidel@suse.de>,
Mathias Weyland <weyland@library.ethz.ch>
Subject: Re: [PATCH] ricoh_mmc: Handle newer models of Ricoh controllers
Date: Tue, 25 Nov 2008 11:45:26 +0100 [thread overview]
Message-ID: <20081125114526.715ebb23@mjolnir.drzeus.cx> (raw)
In-Reply-To: <492BBA91.5010302@overt.org>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
On Tue, 25 Nov 2008 00:42:57 -0800
Philip Langdale <philipl@overt.org> wrote:
> The latest generation of laptops are shipping with a newer
> model of Ricoh chip where the firewire controller is the
> primary PCI function but a cardbus controller is also present.
>
> The existing code assumes that if a cardbus controller is,
> present, then it must be the one to manipulate - but the real
> rule is that you manipulate PCI function 0. This patch adds an
> additional constraint that the target must be function 0.
>
> Signed-off-by: Philip Langdale <philipl@overt.org>
> ---
Mathias, please try to test this ASAP so that I can push it to Linus
for .28 (provided it works).
Frank, if possibly it would be useful if you could also test this on
the hardware you wrote your patch for. Just so we don't break
anything. :)
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-25 10:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 8:42 Philip Langdale
2008-11-25 9:27 ` Mathias Weyland
2008-11-25 10:45 ` Pierre Ossman [this message]
2008-11-26 15:22 ` Frank Seidel
2008-11-26 13:36 ` Frans Pop
2008-11-26 14:42 ` Philip Langdale
2008-11-26 14:45 ` Pierre Ossman
2008-11-26 14:50 ` Matthew Garrett
2008-11-26 14:53 ` Philip Langdale
2008-11-26 15:12 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125114526.715ebb23@mjolnir.drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=fseidel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=philipl@overt.org \
--cc=sdhci-devel@list.drzeus.cx \
--cc=weyland@library.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®