mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Julia Lawall <julia@diku.dk>
Cc: jdmason@kudzu.us, discuss@x86-64.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/5] arch/x86/kernel/pci-calgary_64.c: change simple_strtol to simple_strtoul
Date: Tue, 25 Nov 2008 16:43:55 +0200	[thread overview]
Message-ID: <20081125144355.GB9912@il.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0811251412330.11897@pc-004.diku.dk>

On Tue, Nov 25, 2008 at 02:13:03PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
> 
> Since bridge is unsigned, it would seem better to use simple_strtoul that
> simple_strtol.
> 
> A simplified version of the semantic patch that makes this change is as
> follows: (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @r2@
> long e;
> position p;
> @@
> 
> e = simple_strtol@p(...)
> 
> @@
> position p != r2.p;
> type T;
> T e;
> @@
> 
> e = 
> - simple_strtol@p
> + simple_strtoul
>   (...)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>

Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>

Ingo, can you please push?

Thanks,
Muli
-- 
The First Workshop on I/O Virtualization (WIOV '08)
Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/
                       <->
SYSTOR 2009---The Israeli Experimental Systems Conference
http://www.haifa.il.ibm.com/conferences/systor2009/

  reply	other threads:[~2008-11-25 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 13:13 Julia Lawall
2008-11-25 14:43 ` Muli Ben-Yehuda [this message]
2008-11-26  3:09   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081125144355.GB9912@il.ibm.com \
    --to=muli@il.ibm.com \
    --cc=discuss@x86-64.org \
    --cc=jdmason@kudzu.us \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®