From: Ingo Molnar <mingo@elte.hu>
To: Muli Ben-Yehuda <muli@il.ibm.com>
Cc: Julia Lawall <julia@diku.dk>,
jdmason@kudzu.us, discuss@x86-64.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/5] arch/x86/kernel/pci-calgary_64.c: change simple_strtol to simple_strtoul
Date: Wed, 26 Nov 2008 04:09:41 +0100 [thread overview]
Message-ID: <20081126030938.GD8242@elte.hu> (raw)
In-Reply-To: <20081125144355.GB9912@il.ibm.com>
* Muli Ben-Yehuda <muli@il.ibm.com> wrote:
> On Tue, Nov 25, 2008 at 02:13:03PM +0100, Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > Since bridge is unsigned, it would seem better to use simple_strtoul that
> > simple_strtol.
> >
> > A simplified version of the semantic patch that makes this change is as
> > follows: (http://www.emn.fr/x-info/coccinelle/)
> >
> > // <smpl>
> > @r2@
> > long e;
> > position p;
> > @@
> >
> > e = simple_strtol@p(...)
> >
> > @@
> > position p != r2.p;
> > type T;
> > T e;
> > @@
> >
> > e =
> > - simple_strtol@p
> > + simple_strtoul
> > (...)
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <julia@diku.dk>
>
> Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
>
> Ingo, can you please push?
Sure, applied to tip/x86/urgent, thanks guys!
Ingo
prev parent reply other threads:[~2008-11-26 3:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 13:13 Julia Lawall
2008-11-25 14:43 ` Muli Ben-Yehuda
2008-11-26 3:09 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126030938.GD8242@elte.hu \
--to=mingo@elte.hu \
--cc=discuss@x86-64.org \
--cc=jdmason@kudzu.us \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®