From: Christoph Hellwig <hch@infradead.org>
To: Hannes Eder <hannes@hanneseder.net>
Cc: Christoph Hellwig <hch@infradead.org>,
David Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [XFS] fix sparse warning
Date: Wed, 26 Nov 2008 11:22:14 -0500 [thread overview]
Message-ID: <20081126162214.GA10251@infradead.org> (raw)
In-Reply-To: <154e089b0811260754y191856bfl522f33febfc6e633@mail.gmail.com>
On Wed, Nov 26, 2008 at 04:54:53PM +0100, Hannes Eder wrote:
> Impact: fix sparse warning
>
> Fix the following sparse warning:
>
> fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
> fs/xfs/xfs_inode.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index c6e295e..7a828cb 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -323,7 +323,7 @@ static inline struct inode *VFS_I(struct xfs_inode *ip)
> static inline void xfs_destroy_inode(struct xfs_inode *ip)
> {
> make_bad_inode(VFS_I(ip));
> - return destroy_inode(VFS_I(ip));
> + destroy_inode(VFS_I(ip));
> }
Yes, this makes sense. Thanks for the patch.
prev parent reply other threads:[~2008-11-26 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 15:54 Hannes Eder
2008-11-26 16:22 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126162214.GA10251@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®