* [PATCH] [XFS] fix sparse warning
@ 2008-11-26 15:54 Hannes Eder
2008-11-26 16:22 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2008-11-26 15:54 UTC (permalink / raw)
To: Christoph Hellwig, David Chinner, linux-kernel, kernel-janitors
Impact: fix sparse warning
Fix the following sparse warning:
fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
fs/xfs/xfs_inode.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
index c6e295e..7a828cb 100644
--- a/fs/xfs/xfs_inode.h
+++ b/fs/xfs/xfs_inode.h
@@ -323,7 +323,7 @@ static inline struct inode *VFS_I(struct xfs_inode *ip)
static inline void xfs_destroy_inode(struct xfs_inode *ip)
{
make_bad_inode(VFS_I(ip));
- return destroy_inode(VFS_I(ip));
+ destroy_inode(VFS_I(ip));
}
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [XFS] fix sparse warning
2008-11-26 15:54 [PATCH] [XFS] fix sparse warning Hannes Eder
@ 2008-11-26 16:22 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2008-11-26 16:22 UTC (permalink / raw)
To: Hannes Eder
Cc: Christoph Hellwig, David Chinner, linux-kernel, kernel-janitors
On Wed, Nov 26, 2008 at 04:54:53PM +0100, Hannes Eder wrote:
> Impact: fix sparse warning
>
> Fix the following sparse warning:
>
> fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
> fs/xfs/xfs_inode.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index c6e295e..7a828cb 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -323,7 +323,7 @@ static inline struct inode *VFS_I(struct xfs_inode *ip)
> static inline void xfs_destroy_inode(struct xfs_inode *ip)
> {
> make_bad_inode(VFS_I(ip));
> - return destroy_inode(VFS_I(ip));
> + destroy_inode(VFS_I(ip));
> }
Yes, this makes sense. Thanks for the patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-26 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-26 15:54 [PATCH] [XFS] fix sparse warning Hannes Eder
2008-11-26 16:22 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®