From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: mpm@selenic.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Stop scaring users with "treason uncloaked!"
Date: Thu, 18 Dec 2008 16:08:15 -0800 (PST) [thread overview]
Message-ID: <20081218.160815.106790562.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0812190028560.12061@wrl-59.cs.helsinki.fi>
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Fri, 19 Dec 2008 00:33:46 +0200 (EET)
> On Thu, 18 Dec 2008, Matt Mackall wrote:
>
> > These debug messages are uninformative and extremely alarming. Rather
> > than reporting a peer as a treacherous attacker, report it more
> > correctly as simply broken.
>
> Last time (well, ignoring some report on ancient vendor kernel) I've seen
> this to trigger it wasn't the fault of the peer but ours (we sent past the
> advertized window and window ended up being shrunk to zero). I agree that
> the message as-is is not very good but your change is not very good
> either.
...
> This won't apply to net-next on which you should base anything new (and
> net related).
Agreed.
next prev parent reply other threads:[~2008-12-19 0:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 22:16 Matt Mackall
2008-12-18 22:33 ` Ilpo Järvinen
2008-12-18 22:36 ` Herbert Xu
2008-12-18 23:50 ` Matt Mackall
2008-12-19 0:15 ` David Miller
2008-12-19 3:49 ` Matt Mackall
2008-12-19 3:54 ` David Miller
2008-12-19 18:13 ` markus reichelt
2008-12-19 0:08 ` David Miller [this message]
2008-12-18 22:44 ` Herbert Xu
2008-12-18 22:49 ` Alan Cox
2008-12-18 23:02 ` Herbert Xu
2008-12-18 23:14 ` Alan Cox
2008-12-19 0:07 ` David Miller
2008-12-18 23:06 ` Matt Mackall
2008-12-19 0:45 ` David Schwartz
2008-12-19 0:55 ` Krzysztof Halasa
2008-12-19 0:58 ` Rick Jones
2009-01-26 17:46 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218.160815.106790562.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®