From: David Miller <davem@davemloft.net>
To: mpm@selenic.com
Cc: ilpo.jarvinen@helsinki.fi, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] Stop scaring users with "treason uncloaked!"
Date: Thu, 18 Dec 2008 19:54:33 -0800 (PST) [thread overview]
Message-ID: <20081218.195433.203436159.davem@davemloft.net> (raw)
In-Reply-To: <1229658561.3726.602.camel@calx>
From: Matt Mackall <mpm@selenic.com>
Date: Thu, 18 Dec 2008 21:49:21 -0600
> On Thu, 2008-12-18 at 16:15 -0800, David Miller wrote:
> > From: Matt Mackall <mpm@selenic.com>
> > Date: Thu, 18 Dec 2008 17:50:34 -0600
> >
> > > If you want, we can instead say "Peer %d unexpectedly shrunk window...".
> > > So long as the scary bit is gone, I don't care.
> >
> > Since we have established that the blame is equally possible to
> > be the local as the remote system, something like:
> >
> > TCP: Unexpected shrink of advertised window detected ...
> >
> > is probably the best.
>
> How's this:
>
> The original message was unhelpful and extremely alarming to our poor
> users, despite its charm. Make it less frightening.
>
> Signed-off-by: Matt Mackall <mpm@selenic.com>
Looks good, applied, thanks Matt.
next prev parent reply other threads:[~2008-12-19 3:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 22:16 Matt Mackall
2008-12-18 22:33 ` Ilpo Järvinen
2008-12-18 22:36 ` Herbert Xu
2008-12-18 23:50 ` Matt Mackall
2008-12-19 0:15 ` David Miller
2008-12-19 3:49 ` Matt Mackall
2008-12-19 3:54 ` David Miller [this message]
2008-12-19 18:13 ` markus reichelt
2008-12-19 0:08 ` David Miller
2008-12-18 22:44 ` Herbert Xu
2008-12-18 22:49 ` Alan Cox
2008-12-18 23:02 ` Herbert Xu
2008-12-18 23:14 ` Alan Cox
2008-12-19 0:07 ` David Miller
2008-12-18 23:06 ` Matt Mackall
2008-12-19 0:45 ` David Schwartz
2008-12-19 0:55 ` Krzysztof Halasa
2008-12-19 0:58 ` Rick Jones
2009-01-26 17:46 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218.195433.203436159.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®