mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Mario Schwalbe <schwalbe@inf.tu-dresden.de>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	linux-kernel@vger.kernel.org,
	Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ide: Fix ata_id_has_dword_io to return DWORD I/O support properly
Date: Thu, 18 Dec 2008 18:10:15 +0000	[thread overview]
Message-ID: <20081218181015.2e160d5c@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <494A837A.50801@garzik.org>

> This seems like a risky assumption...

Its wrong on various counts

- ata_id_major_version can't tell early ATA versions apart
- on anything later than the early ISA IDE paddles (the ones that
basically were just bus decoders) its invisible to the drive

Except for legacy ISA bus controllers (and even there it is questionable)
I would favour simply ignoring it.

The reverse half of the problem (the fact the ATA8 drafts reuse it and
can cause confusion if your device is treacherous computing crippled) is
IMHO just amusing 8)


  parent reply	other threads:[~2008-12-18 18:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18 14:18 Mario Schwalbe
2008-12-18 17:08 ` Jeff Garzik
2008-12-18 17:24   ` Sergei Shtylyov
2008-12-18 20:42     ` Bartlomiej Zolnierkiewicz
2008-12-18 22:40       ` Alan Cox
2008-12-18 23:13         ` Bartlomiej Zolnierkiewicz
2008-12-19 10:50           ` Alan Cox
2008-12-19 19:30             ` Bartlomiej Zolnierkiewicz
2008-12-20  0:10               ` Alan Cox
2008-12-19 11:31         ` Sergei Shtylyov
2008-12-19 11:34           ` Sergei Shtylyov
2008-12-18 18:10   ` Alan Cox [this message]
2008-12-20  1:58     ` Robert Hancock
2008-12-20 13:25       ` Sergei Shtylyov
2008-12-22 20:16         ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081218181015.2e160d5c@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwalbe@inf.tu-dresden.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®