From: Pavel Machek <pavel@suse.cz>
To: Paul.Clements@steeleye.com,
kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: nbd: clean up error handling
Date: Thu, 18 Dec 2008 19:21:09 +0100 [thread overview]
Message-ID: <20081218182108.GA13546@elf.ucw.cz> (raw)
Uses existing error_out: label instead of hardcoding error action.
Signed-off-by: Pavel Machek <pavel@suse.cz>
---
commit d4bf0663fe12e5536360b2b9a3df3f49cdb7ef76
tree b5b88ccf8008e135a972415f186b8a93cecb184c
parent 70b683565a6bfdb95a367b47509c2bc5db54c33f
author Pavel <pavel@amd.ucw.cz> Thu, 18 Dec 2008 19:20:21 +0100
committer Pavel <pavel@amd.ucw.cz> Thu, 18 Dec 2008 19:20:21 +0100
drivers/block/nbd.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index d3a91ca..f0b8ee2 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -465,9 +465,7 @@ static void nbd_handle_req(struct nbd_de
mutex_unlock(&lo->tx_lock);
printk(KERN_ERR "%s: Attempted send on closed socket\n",
lo->disk->disk_name);
- req->errors++;
- nbd_end_request(req);
- return;
+ goto error_out;
}
lo->active_req = req;
@@ -475,8 +473,7 @@ static void nbd_handle_req(struct nbd_de
if (nbd_send_req(lo, req) != 0) {
printk(KERN_ERR "%s: Request send failed\n",
lo->disk->disk_name);
- req->errors++;
- nbd_end_request(req);
+ goto error_out;
} else {
spin_lock(&lo->queue_lock);
list_add(&req->queuelist, &lo->queue_head);
@@ -563,7 +560,7 @@ static int nbd_ioctl(struct block_device
struct nbd_device *lo = bdev->bd_disk->private_data;
struct file *file;
int error;
- struct request sreq ;
+ struct request sreq;
struct task_struct *thread;
if (!capable(CAP_SYS_ADMIN))
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next reply other threads:[~2008-12-18 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 18:21 Pavel Machek [this message]
2008-12-18 19:15 ` Paul Clements
2008-12-28 8:03 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218182108.GA13546@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=Paul.Clements@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome