From: Pavel Machek <pavel@suse.cz>
To: Paul Clements <paul.clements@steeleye.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: nbd: clean up error handling
Date: Sun, 28 Dec 2008 09:03:30 +0100 [thread overview]
Message-ID: <20081228080330.GB1600@ucw.cz> (raw)
In-Reply-To: <494AA15B.2010000@steeleye.com>
On Thu 2008-12-18 14:15:39, Paul Clements wrote:
> Hi Pavel,
>
> hanks for the patch...
>
> Pavel Machek wrote:
>> Uses existing error_out: label instead of hardcoding error action.
>>
>> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
>> @@ -475,8 +473,7 @@ static void nbd_handle_req(struct nbd_de
>> if (nbd_send_req(lo, req) != 0) {
>> printk(KERN_ERR "%s: Request send failed\n",
>> lo->disk->disk_name);
>> - req->errors++;
>> - nbd_end_request(req);
>> + goto error_out;
>
> This one is not correct. We don't return immediately here.
Sorry about that. Will do next series shortly...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2008-12-28 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 18:21 Pavel Machek
2008-12-18 19:15 ` Paul Clements
2008-12-28 8:03 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081228080330.GB1600@ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.clements@steeleye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®