mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Federico Heinz <fheinz@vialibre.org.ar>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Andrew Paprocki" <andrew@ishiboo.com>,
	LKML <linux-kernel@vger.kernel.org>,
	dz@debian.org, "Andy Spencer" <spenceal@rose-hulman.edu>
Subject: Re: i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1
Date: Sun, 21 Dec 2008 21:25:39 -0200	[thread overview]
Message-ID: <20081221212539.1fa72bd8@lauren> (raw)
In-Reply-To: <20081221144109.2ed26cf2@lxorguk.ukuu.org.uk>

On 21/12/2008, Alan Cox wrote:
> I can find no copies of them with Signed-off-by: lines so they appear to
> have escaped. If the authors of those changes would care to provided
> Signed-off-by: lines I'll chase this up further.

This trivial patch adds support for i8k on the new Dell Vostro models.
I tested it on my Vostro 1400, and it works. It does print a warning
when loading the module:

	i8k: unable to get SMM BIOS version

But I couldn't figure out how to fix that. The module seems to work fine,
anyway...

Signed-off-by: Federico Heinz <fheinz@vialibre.org.ar>

--- drivers/char/i8k.c.orig     2007-07-08 20:32:17.000000000 -0300
+++ drivers/char/i8k.c  2007-09-27 03:06:08.000000000 -0300
@@ -439,6 +439,13 @@
                        DMI_MATCH(DMI_PRODUCT_NAME, "Latitude"),
                },
        },
+       {
+               .ident = "Dell Vostro",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "Vostro"),
+               },
+       },
        { }
 };

  reply	other threads:[~2008-12-21 23:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18  0:34 Andrew Paprocki
2008-12-18  1:07 ` Andrew Paprocki
2008-12-18  6:22   ` Andrew Morton
2008-12-18  7:53     ` Andrew Paprocki
2008-12-21 20:05       ` Matthew Garrett
2008-12-21 14:41   ` Alan Cox
2008-12-21 23:25     ` Federico Heinz [this message]
2008-12-22  0:09     ` Andy Spencer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081221212539.1fa72bd8@lauren \
    --to=fheinz@vialibre.org.ar \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andrew@ishiboo.com \
    --cc=dz@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spenceal@rose-hulman.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®