mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andrew Paprocki" <andrew@ishiboo.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: dz@debian.org
Subject: i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1
Date: Wed, 17 Dec 2008 19:34:26 -0500	[thread overview]
Message-ID: <76366b180812171634k6c5a25d6uad0de0d6c514ebb5@mail.gmail.com> (raw)

I see two problems with the i8k module and the Dell XPS M1530. First,
the laptop is not detected. Second, even if it is detected, the module
prints that it is unable to get the SMM BIOS version even though the
module appears to be working:

# modprobe i8k force=1
# dmesg | grep i8k
[  547.007217] i8k: not running on a supported Dell system.
[  547.007234] i8k: vendor=Dell Inc., model=XPS M1530
     , version=A08
[  547.007629] i8k: unable to get SMM BIOS version
# cat /proc/i8k
1.0 A08 5D26YF1 53 0 0 0 0 -1 -22

Information from DMI:

BIOS Information
        Vendor: Dell Inc.
        Version: A08
        Release Date: 03/19/2008

System Information
        Manufacturer: Dell Inc.
        Product Name: XPS M1530

It seems straightforward to add a record for the auto-detection, but
I'm not sure how generic it should be. From looking online, it appears
the M1330, M1530, and M1730 all need to be detected. Perhaps it should
just be "Dell XPS M Series" and only match on "XPS M"? Does anyone
else on the list use these laptops?

Thanks,
-Andrew

--- a/drivers/char/i8k.c
+++ b/drivers/char/i8k.c
@@ -485,6 +485,13 @@ static struct dmi_system_id __initdata i8k_dmi_table[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "MP061"),
                },
        },
+       {
+               .ident = "Dell XPS M1530",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "XPS M1530"),
+               },
+       },
        { }
 };

             reply	other threads:[~2008-12-18  0:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18  0:34 Andrew Paprocki [this message]
2008-12-18  1:07 ` Andrew Paprocki
2008-12-18  6:22   ` Andrew Morton
2008-12-18  7:53     ` Andrew Paprocki
2008-12-21 20:05       ` Matthew Garrett
2008-12-21 14:41   ` Alan Cox
2008-12-21 23:25     ` Federico Heinz
2008-12-22  0:09     ` Andy Spencer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76366b180812171634k6c5a25d6uad0de0d6c514ebb5@mail.gmail.com \
    --to=andrew@ishiboo.com \
    --cc=dz@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®