From: sangsu <sangsu@gmail.com>
To: linux-usb@vger.kernel.org
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
david-b@pacbell.net
Subject: [PATCH]USB:Fix goku_udc usb speed handling
Date: Fri, 2 Jan 2009 01:11:14 +0900 [thread overview]
Message-ID: <20090101161114.GA7977@sangsu-desktop> (raw)
The usb gadget framework revealed weakness in the godu_udc
gadget driver register function. Instead of checking if
speed asked for was USB_LOW_SPEED upon usb_gadget_register()
to deny service, it checked only for USB_FULL_SPEED, thus
denying service to usb high speed capable gadgets.
Signed-off-by: SangSu Park<sangsu@gmail.com>
---
drivers/usb/gadget/goku_udc.c |2+-
1 files changed, 1 insertion(+), 1 deletions(-)
--- a/drivers/usb/gadget/goku_udc.c 2008-12-30 23:24:02.000000000 +0900
+++ b/drivers/usb/gadget/goku_udc.c 2009-01-02 00:49:15.000000000 +0900
@@ -1349,7 +1349,7 @@
int retval;
if (!driver
- || driver->speed != USB_SPEED_FULL
+ || driver->speed < USB_SPEED_FULL
|| !driver->bind
|| !driver->disconnect
|| !driver->setup)
next reply other threads:[~2009-01-01 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 16:11 sangsu [this message]
2009-01-05 22:46 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090101161114.GA7977@sangsu-desktop \
--to=sangsu@gmail.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®