* [PATCH]USB:Fix goku_udc usb speed handling
@ 2009-01-01 16:11 sangsu
2009-01-05 22:46 ` David Brownell
0 siblings, 1 reply; 2+ messages in thread
From: sangsu @ 2009-01-01 16:11 UTC (permalink / raw)
To: linux-usb; +Cc: stern, linux-kernel, david-b
The usb gadget framework revealed weakness in the godu_udc
gadget driver register function. Instead of checking if
speed asked for was USB_LOW_SPEED upon usb_gadget_register()
to deny service, it checked only for USB_FULL_SPEED, thus
denying service to usb high speed capable gadgets.
Signed-off-by: SangSu Park<sangsu@gmail.com>
---
drivers/usb/gadget/goku_udc.c |2+-
1 files changed, 1 insertion(+), 1 deletions(-)
--- a/drivers/usb/gadget/goku_udc.c 2008-12-30 23:24:02.000000000 +0900
+++ b/drivers/usb/gadget/goku_udc.c 2009-01-02 00:49:15.000000000 +0900
@@ -1349,7 +1349,7 @@
int retval;
if (!driver
- || driver->speed != USB_SPEED_FULL
+ || driver->speed < USB_SPEED_FULL
|| !driver->bind
|| !driver->disconnect
|| !driver->setup)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH]USB:Fix goku_udc usb speed handling
2009-01-01 16:11 [PATCH]USB:Fix goku_udc usb speed handling sangsu
@ 2009-01-05 22:46 ` David Brownell
0 siblings, 0 replies; 2+ messages in thread
From: David Brownell @ 2009-01-05 22:46 UTC (permalink / raw)
To: sangsu; +Cc: linux-usb, stern, linux-kernel
On Thursday 01 January 2009, sangsu wrote:
> The usb gadget framework revealed weakness in the godu_udc
> gadget driver register function. Instead of checking if
> speed asked for was USB_LOW_SPEED upon usb_gadget_register()
> to deny service, it checked only for USB_FULL_SPEED, thus
> denying service to usb high speed capable gadgets.
>
> Signed-off-by: SangSu Park<sangsu@gmail.com>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Good to know this USB peripheral driver is getting some use. :)
> ---
> drivers/usb/gadget/goku_udc.c |2+-
> 1 files changed, 1 insertion(+), 1 deletions(-)
>
>
> --- a/drivers/usb/gadget/goku_udc.c 2008-12-30 23:24:02.000000000 +0900
> +++ b/drivers/usb/gadget/goku_udc.c 2009-01-02 00:49:15.000000000 +0900
> @@ -1349,7 +1349,7 @@
> int retval;
>
> if (!driver
> - || driver->speed != USB_SPEED_FULL
> + || driver->speed < USB_SPEED_FULL
> || !driver->bind
> || !driver->disconnect
> || !driver->setup)
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-05 22:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-01 16:11 [PATCH]USB:Fix goku_udc usb speed handling sangsu
2009-01-05 22:46 ` David Brownell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®