From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <srostedt@redhat.com>, Ingo Molnar <mingo@elte.hu>,
"David S. Miller" <davem@davemloft.net>,
sparclinux <sparclinux@vger.kernel.org>
Subject: Re: ftrace breaks sparc64 build
Date: Tue, 6 Jan 2009 10:45:37 +0100 [thread overview]
Message-ID: <20090106094537.GB5061@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0901052326180.30989@gandalf.stny.rr.com>
On Mon, Jan 05, 2009 at 11:30:58PM -0500, Steven Rostedt wrote:
> On Tue, 6 Jan 2009, Heiko Carstens wrote:
> Sam and Heiko,
>
> I'm trying to see if the (a ? b : c) construct is causing the issue. Can
> you test this patch.
>
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index d95da10..e13ad24 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -113,7 +113,8 @@ void ftrace_likely_update(struct ftrace_branch_data *f, int val, int expect);
> * "Define 'is'", Bill Clinton
> * "Define 'if'", Steven Rostedt
> */
> -#define if(cond) if (__builtin_constant_p((cond)) ? !!(cond) : \
> +#define if(cond) if ((__builtin_constant_p((cond)) && !!(cond)) || \
> + (!__builtin_constant_p((cond)) && \
Doesn't help unfortunately.
next prev parent reply other threads:[~2009-01-06 9:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 18:19 Sam Ravnborg
2009-01-05 19:31 ` Steven Rostedt
2009-01-05 19:42 ` [PATCH] sparc: make proces_ver_nack a bit more readable Steven Rostedt
2009-01-05 19:46 ` Steven Rostedt
2009-01-05 19:56 ` Steven Rostedt
2009-01-05 20:07 ` Sam Ravnborg
2009-01-05 20:08 ` Sam Ravnborg
2009-01-06 18:23 ` David Miller
2009-01-05 19:54 ` ftrace breaks sparc64 build Sam Ravnborg
2009-01-05 20:05 ` Steven Rostedt
2009-01-05 21:31 ` Sam Ravnborg
2009-01-05 21:52 ` Steven Rostedt
2009-01-05 22:01 ` Sam Ravnborg
2009-01-05 22:14 ` Steven Rostedt
2009-01-05 23:11 ` Heiko Carstens
2009-01-06 2:07 ` Steven Rostedt
2009-01-06 9:36 ` Heiko Carstens
2009-01-06 4:30 ` Steven Rostedt
2009-01-06 9:45 ` Heiko Carstens [this message]
2009-01-06 18:32 ` David Miller
2009-01-06 18:52 ` Steven Rostedt
2009-01-06 19:01 ` David Miller
2009-01-06 19:52 ` Sam Ravnborg
2009-01-06 20:02 ` David Miller
2009-01-05 20:30 ` [PATCH] module: clean up initialization of variable Steven Rostedt
2009-01-05 22:59 ` Harvey Harrison
2009-01-06 1:22 ` Rusty Russell
2009-01-06 2:02 ` Steven Rostedt
2009-01-05 19:48 ` ftrace breaks sparc64 build Al Viro
2009-01-05 19:55 ` Sam Ravnborg
2009-01-06 7:53 ` Jan Beulich
2009-01-06 11:35 ` Al Viro
2009-01-06 12:39 ` Jan Beulich
2009-01-06 13:34 ` Sam Ravnborg
2009-01-06 15:52 ` Al Viro
2009-01-06 18:39 ` David Miller
2009-01-08 9:28 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106094537.GB5061@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®