mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Oliver Neukum <oliver@neukum.org>
Cc: Alan Stern <stern@rowland.harvard.edu>, Greg KH <greg@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Pavel Machek <pavel@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [Regression] USB wakeup problem on Toshiba Portege R500
Date: Thu, 8 Jan 2009 17:36:12 +0100	[thread overview]
Message-ID: <200901081736.12926.rjw@sisk.pl> (raw)
In-Reply-To: <200901080949.34339.oliver@neukum.org>

On Thursday 08 January 2009, Oliver Neukum wrote:
> Am Thursday 08 January 2009 08:35:39 schrieb Rafael J. Wysocki:
> > Hi Alan,
> > 
> > Unfortunately, the following commit:
> > 
> > commit 6fd9086a518d4f14213a32fe6c9ac17fabebbc1e
> > Author: Alan Stern <stern@rowland.harvard.edu>
> > Date:   Wed Dec 17 17:20:38 2008 -0500
> > 
> >     USB: automatically enable wakeup for PCI host controllers
> > 
> >     Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > 
> > causes a regression to appear on my Toshiba Portege R500.
> > 
> > The regression is that when suspended to RAM, the box wakes up immediately
> > unless 'disabled' is written into the /sys/devices/.../power/wakeup file of the
> 
> Even without attached devices?

Yes.  This is a platform problem, no doubt, but this patch makes it painfully
visible.

> > EHCI controller.  I know of at least 10 different boxes out there that are
> > going to have similar problems forcing their users to use manual workaround.
> > 
> > Also, it wakes up on a USB mouse activity, which I don't want it to do, so in
> > fact I have to write 'disabled' to the /sys/devices/.../power/wakeup files of
> > all USB controllers.
> 
> We do support remote wakeup from PS2 keyboards. So you might argue we
> should do the same for USB HID devices.

Well, _I_ can live with a few 'echo disabled > /sys/devices/.../power/wakeup'
lines in my init scripts, but I'm afraid we're going to get many problem
reports related to this.  This means people will likely lose time on trying to
debug this problem and someone will have to handle the reports.  Are you
volunteering to do that?

Also, it would have been nice to notify people of such a change of behavior in
advance.

Thanks,
Rafael

  reply	other threads:[~2009-01-08 16:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08  7:35 Rafael J. Wysocki
2009-01-08  8:49 ` Oliver Neukum
2009-01-08 16:36   ` Rafael J. Wysocki [this message]
2009-01-08 16:48     ` Oliver Neukum
2009-01-08 17:03       ` Rafael J. Wysocki
2009-01-08 18:55         ` Frans Pop
2009-01-08 19:54           ` Rafael J. Wysocki
2009-01-09 15:55           ` Alan Stern
2009-01-09 17:53             ` Rafael J. Wysocki
2009-01-09 22:23               ` Pavel Machek
2009-01-12 21:53               ` Alan Stern
2009-01-12 22:53                 ` Rafael J. Wysocki
2009-01-13  3:10                   ` Alan Stern
2009-01-13 11:13                     ` Rafael J. Wysocki
2009-01-09 10:18       ` Pavel Machek
2009-01-09 10:26         ` Oliver Neukum
2009-01-09 10:36           ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901081736.12926.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=greg@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=oliver@neukum.org \
    --cc=pavel@suse.cz \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®