Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI instructions for x86_64 platform

[Herbert Xu <herbert@gondor.apana.org.au>]

On Fri, Jan 09, 2009 at 08:18:14PM +1100, Herbert Xu wrote:
>
> Not at all, tfms are just "shell" objects and they were designed
> to be used in thie way.  Calling setkey twice is an issue but it's
> not a show-stopper.  We have the same problem in other places to
> so this something that we can potentially optimise.

Here's how we can solve the double setkey problem.  We can make
a new cryptd_alloc_ablkcipher interface that returns a cryptd
ablkcipher object.  Since it's cryptd specific we can then access
its underlying blkcipher object, which can be shared between the
cryptd object and the user of the cryptd object.  This way you
only need to do setkey on the cryptd object and it'll get set
on the underlying blkcipher automatically.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt