From: Herbert Xu <herbert@gondor.apana.org.au>
To: Huang Ying <ying.huang@intel.com>
Cc: Sebastian Siewior <linux-crypto@ml.breakpoint.cc>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI instructions for x86_64 platform
Date: Tue, 13 Jan 2009 13:39:38 +1100 [thread overview]
Message-ID: <20090113023937.GA14460@gondor.apana.org.au> (raw)
In-Reply-To: <1231814053.5937.120.camel@yhuang-dev.sh.intel.com>
On Tue, Jan 13, 2009 at 10:34:13AM +0800, Huang Ying wrote:
>
> static void ablk_complete(struct crypto_async_request *req, int err)
> {
> struct ablkcipher_request *ablk_req = ablkcipher_request_cast(req);
> struct async_aes_req_ctx *req_ctx =
> ablk_aes_req_ctx(ablk_req, crypto_ablkcipher_reqtfm(ablk_req));
This is not guaranteed to work. Your completion caller may be
called with a request pointer other than the one that you passed
to it. The only thing we guarantee is that req->data has the
value that you set at the beginning.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2009-01-13 2:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 2:02 Huang Ying
2009-01-09 7:01 ` Herbert Xu
2009-01-09 8:54 ` Huang Ying
2009-01-09 9:18 ` Herbert Xu
2009-01-10 10:08 ` Herbert Xu
2009-01-12 2:30 ` Huang Ying
2009-01-12 3:06 ` Herbert Xu
2009-01-12 6:55 ` Huang Ying
2009-01-12 10:43 ` Herbert Xu
2009-01-13 2:34 ` Huang Ying
2009-01-13 2:39 ` Herbert Xu [this message]
2009-01-13 2:49 ` Huang Ying
2009-01-13 2:53 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113023937.GA14460@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@ml.breakpoint.cc \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®