From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Ingo Molnar <mingo@elte.hu>, Jeff Garzik <jeff@garzik.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-ide@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [bisected] Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()
Date: Sun, 11 Jan 2009 00:10:38 +0000 [thread overview]
Message-ID: <20090111001038.33943d2e@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4968FFD7.6070302@ru.mvista.com>
> >> data_xfer transfers 18 bytes + 2 padding (correctly) -> 20 bytes
>
> Correctly indeed? I'm not at all sure it's correct to read an extra
> 16-bit word off the device when it thinks it's already done with the
> data transfer.
The VLB controller docs explicitly require you do entirely 32bit. The AMD
ones seem to imply you should.
Its easy enough to not do that but for the VLB case we have to so the
WARN needs fixing which ever path we go down.
next prev parent reply other threads:[~2009-01-11 0:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 12:34 Christian Borntraeger
2009-01-09 12:44 ` Alan Cox
2009-01-09 13:09 ` Christian Borntraeger
2009-01-10 9:09 ` Christian Borntraeger
2009-01-10 10:41 ` Alan Cox
2009-01-10 11:42 ` Christian Borntraeger
2009-01-10 11:49 ` Sergei Shtylyov
2009-01-10 12:21 ` Alan Cox
2009-01-10 13:01 ` Sergei Shtylyov
2009-01-10 13:55 ` Alan Cox
2009-01-10 13:04 ` Christian Borntraeger
2009-01-10 13:14 ` Jeff Garzik
2009-01-10 13:27 ` Christian Borntraeger
2009-01-10 13:51 ` Alan Cox
2009-01-10 21:21 ` Arjan van de Ven
2009-01-10 13:07 ` Ingo Molnar
2009-01-10 13:12 ` Jeff Garzik
2009-01-10 13:24 ` Ingo Molnar
2009-01-10 13:36 ` [bisected] " Ingo Molnar
2009-01-10 13:57 ` Alan Cox
2009-01-10 15:10 ` Sergei Shtylyov
2009-01-10 15:28 ` Alan Cox
2009-01-10 15:59 ` Sergei Shtylyov
2009-01-10 20:06 ` Sergei Shtylyov
2009-01-10 20:31 ` Jeff Garzik
2009-01-10 20:50 ` Sergei Shtylyov
2009-01-11 0:10 ` Alan Cox [this message]
2009-01-11 9:18 ` Sergei Shtylyov
2009-01-11 11:24 ` Alan Cox
2009-01-13 9:38 ` [PATCH] ata: fix wrong WARN_ON_ONCE Christian Borntraeger
2009-01-10 13:57 ` [bisected] Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750() Christian Borntraeger
2009-01-10 13:53 ` Alan Cox
2009-01-10 14:36 ` James Bottomley
2009-01-10 15:03 ` Jeff Garzik
2009-01-10 15:12 ` Alan Cox
2009-01-10 15:22 ` James Bottomley
2009-01-10 15:29 ` Alan Cox
2009-01-10 15:34 ` Sergei Shtylyov
2009-01-10 15:29 ` Sergei Shtylyov
2009-01-10 15:32 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090111001038.33943d2e@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=borntraeger@de.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®