Re: build breakage -- paravirt_{alloc,free}_ldt

[Ingo Molnar <mingo@elte.hu>]

* Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:

> On Mon, Jan 12, 2009 at 4:27 PM, Jaswinder Singh Rajput
> <jaswinderlinux@gmail.com> wrote:
> > On Mon, Jan 12, 2009 at 4:22 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >>
> >> * Jiri Kosina <jkosina@suse.cz> wrote:
> >>
> >>> Hi,
> >>>
> >>> with Linus' tree (ae04d14015) doesn't build for me with
> >>>
> >>> arch/x86/kernel/ldt.c: In function 'alloc_ldt':
> >>> arch/x86/kernel/ldt.c:55: error: implicit declaration of function 'paravirt_alloc_ldt'
> >>> arch/x86/kernel/ldt.c:79: error: implicit declaration of function 'paravirt_free_ldt'
> >>>
> >>> Config on http://www.jikos.cz/jikos/junk/.config
> >>
> >> hm, it builds fine here with your config. Did .28 build fine for you? The
> >> only change to this file since .28 has been Jaswinder's "423a540: x86:
> >> ldt.c fix style problems".
> >>
> >
> > No, it is not because of my patch but I will check for the solution.
> >
> >
> 
> With your config I am also not getting any error with -tip tree:
> 
>   CC      arch/x86/kernel/dumpstack_64.o
>   CC      arch/x86/kernel/time_64.o
>   CC      arch/x86/kernel/ioport.o
>   CC      arch/x86/kernel/ldt.o
>   CC      arch/x86/kernel/dumpstack.o
> 
> Jiri, make clean and also check for -tip tree.

It could be an unclean build tree. Jiri, could you double-check that 
you've got the right kernel and if it still triggers, could you 
investigate where this build error could come from?

ldt.c includes asm/paravirt.h already, via asm/mmu_context.h, so it should 
be picking up the paravirt_alloc/free_ldt() definitions.

	Ingo