Re: build breakage -- paravirt_{alloc,free}_ldt

[Ingo Molnar <mingo@elte.hu>]

* Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:

> On Mon, Jan 12, 2009 at 4:54 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:
> >
> >> On Mon, Jan 12, 2009 at 4:42 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> >> > On Mon, 12 Jan 2009, Ingo Molnar wrote:
> >> >
> >> >> > with Linus' tree (ae04d14015) doesn't build for me with
> >> >> >
> >> >> > arch/x86/kernel/ldt.c: In function 'alloc_ldt':
> >> >> > arch/x86/kernel/ldt.c:55: error: implicit declaration of function 'paravirt_alloc_ldt'
> >> >> > arch/x86/kernel/ldt.c:79: error: implicit declaration of function 'paravirt_free_ldt'
> >> >> >
> >> >> > Config on http://www.jikos.cz/jikos/junk/.config
> >> >>
> >> >> hm, it builds fine here with your config. Did .28 build fine for you? The
> >> >> only change to this file since .28 has been Jaswinder's "423a540: x86:
> >> >> ldt.c fix style problems".
> >> >
> >> > Puzzled. On one system, I still get this build error even after make
> >> > mrpoper (I use this machine to build kernel routinely, so it certainly
> >> > didn't happen a few days ago).
> >> >
> >> > But I just tried on different system, and there is builds flawlessly. It's
> >> > gcc 4.3.1 vs 4.3.2. I will check a little bit more.
> >> >
> >>
> >> I am using gcc 4.3.2
> >>
> >> Please check 'git diff' if by mistake some thing is gone wrong or check
> >> 'git log'
> >
> > That wont show working tree corruption.
> >
> 
> It works for me for my old 166 MHz pentium machine after crashing the 
> system, 'git diff' tells which files are broken ;-)

That's cool from Git :-)

Thinking about it, it might not necessarily detect all corruption patterns 
though: git diff is sys_lstat() driven - so if a corruption corrupts a 
single block on the filesystem (in a working tree file), git diff wont 
know about that.

	Ingo