From: Andy Whitcroft <apw@canonical.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: checkpatch warning of struct indentation
Date: Mon, 12 Jan 2009 18:51:14 +0000 [thread overview]
Message-ID: <20090112185114.GB13925@shadowen.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0901121253350.22796@gandalf.stny.rr.com>
On Mon, Jan 12, 2009 at 12:57:23PM -0500, Steven Rostedt wrote:
>
> Hi,
>
> I'm now seeing the following warnings from checkpatch:
>
> #325: FILE: kernel/trace/trace_stat.c:21:
> + void *stat;
>
> ERROR: "foo *bar" should be "foo *bar"
> #334: FILE: kernel/trace/trace_stat.c:27:
> + struct tracer_stat *ts;
>
> ERROR: "foo *bar" should be "foo *bar"
> #337: FILE: kernel/trace/trace_stat.c:30:
> + struct dentry *file;
Yes those are bogus. They should be fixed in the latest push to akpm.
You can check that with this version:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
-apw
prev parent reply other threads:[~2009-01-12 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 17:57 Steven Rostedt
2009-01-12 18:09 ` Frédéric Weisbecker
2009-01-12 18:35 ` Steven Rostedt
2009-01-12 19:34 ` Frederic Weisbecker
2009-01-13 14:45 ` Johannes Weiner
2009-01-13 14:54 ` Steven Rostedt
2009-01-13 15:23 ` Johannes Weiner
2009-01-12 18:20 ` Ingo Molnar
2009-01-12 18:51 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112185114.GB13925@shadowen.org \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®