From: "Matt Carlson" <mcarlson@broadcom.com>
To: "David Miller" <davem@davemloft.net>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
"Valdis.Kletnieks@vt.edu" <Valdis.Kletnieks@vt.edu>,
"alessandro.suardi@gmail.com" <alessandro.suardi@gmail.com>,
"jaswinderlinux@gmail.com" <jaswinderlinux@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: 2.6.28-git8: tg3 doesn't work due to firmware not loading (-git7 is ok)
Date: Tue, 13 Jan 2009 10:39:48 -0800 [thread overview]
Message-ID: <20090113183948.GA21847@xw6200.broadcom.net> (raw)
In-Reply-To: <20090111.133929.57600645.davem@davemloft.net>
On Sun, Jan 11, 2009 at 01:39:29PM -0800, David Miller wrote:
> From: David Woodhouse <dwmw2@infradead.org>
> Date: Sun, 11 Jan 2009 12:24:58 +0000
>
> > Other drivers will load the firmware later, at the time the device is
> > brought up. This means that even if you build the driver into the kernel
> > without its firmware, it can still request the firmware later, when you
> > try to start _using_ it. And when the file system is available.
>
> For example, for mounting an NFS root using that device.... Oh, will I
> need an initramfs for that once you pull the firmware-in-kernel
> option?
>
> To me, device probe is in fact the place to fail firmware discovery
> for networking devices. Because such a failure can mean you can't
> mount your root filesystem.
David, is this the direction you want to take the fix? I'm sitting on
a patch that elaborates on David Woodhouse's work which moves the
request_firmware call to tg3_open(). Before I posted it for comment,
I wanted to make sure the patch is moving in the right direction.
next prev parent reply other threads:[~2009-01-13 18:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 14:24 Alessandro Suardi
2009-01-08 4:03 ` Alessandro Suardi
2009-01-08 6:12 ` Jaswinder Singh Rajput
2009-01-08 20:33 ` Alessandro Suardi
2009-01-08 20:53 ` David Miller
2009-01-09 17:30 ` Alessandro Suardi
2009-01-09 22:04 ` David Miller
2009-01-09 22:29 ` Alessandro Suardi
2009-01-11 11:10 ` Valdis.Kletnieks
2009-01-11 12:08 ` David Miller
2009-01-11 12:24 ` David Woodhouse
2009-01-11 12:59 ` David Woodhouse
2009-01-11 16:42 ` Alessandro Suardi
2009-01-11 16:53 ` David Woodhouse
2009-01-11 19:24 ` Alessandro Suardi
2009-01-11 19:26 ` David Woodhouse
2009-01-11 16:48 ` Valdis.Kletnieks
2009-01-11 16:56 ` David Woodhouse
2009-01-11 21:49 ` David Miller
2009-01-11 22:29 ` Valdis.Kletnieks
2009-01-11 22:46 ` David Woodhouse
2009-01-11 21:41 ` David Miller
2009-01-12 0:10 ` Valdis.Kletnieks
2009-01-12 1:39 ` Valdis.Kletnieks
2009-01-12 8:13 ` David Woodhouse
2009-01-13 4:46 ` Valdis.Kletnieks
2009-01-13 5:52 ` Valdis.Kletnieks
2009-01-11 21:39 ` David Miller
2009-01-11 22:02 ` David Woodhouse
2009-01-11 22:05 ` David Miller
2009-01-11 22:41 ` David Woodhouse
2009-01-13 6:13 ` Willy Tarreau
2009-01-11 22:15 ` David Woodhouse
2009-01-11 22:19 ` David Miller
2009-01-13 18:39 ` Matt Carlson [this message]
2009-01-13 20:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113183948.GA21847@xw6200.broadcom.net \
--to=mcarlson@broadcom.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alessandro.suardi@gmail.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=jaswinderlinux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®