mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@sirena.org.uk>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: LKML <linux-kernel@vger.kernel.org>, Liam Girdwood <lrg@kernel.org>
Subject: Re: regulator: Add always off to constraints.
Date: Tue, 20 Jan 2009 12:43:41 +0000	[thread overview]
Message-ID: <20090120124338.GA31521@sirena.org.uk> (raw)
In-Reply-To: <4975BE69.5040106@cam.ac.uk>

On Tue, Jan 20, 2009 at 12:07:05PM +0000, Jonathan Cameron wrote:

> 1) interaction between always on and always off.  Obviously it's
> a bit odd if both are set. Currently I'm giving always on preference.

I'd just complain loudly and refuse to accept the constraints if they
are clearly broken like that.

One thing I would suggest is a slightly weaker version which marks the
regulator to be turned off at boot rather than always off.  That's
slightly more flexible and would achieve the same effect if the
constraints don't otherwise allow for turning the regulator on layer.

> 2) Doesn't really make sense to have regulators that are always
> disabled available under sysfs etc.  Perhaps there is a lower
> level way of doing this that I'm missing?  There is not easy
> way of permanently saving this stuff on the da9030 that I'm
> using and moving it into the bootloader would be a pain.

It doesn't do *that* much harm - if nothing else it makes it more
discoverable what's happening.

  reply	other threads:[~2009-01-20 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 12:07 Jonathan Cameron
2009-01-20 12:43 ` Mark Brown [this message]
2009-01-20 13:00   ` Jonathan Cameron
2009-01-20 13:19     ` regulator: Add disable_on_boot flag " Jonathan Cameron
2009-01-20 20:14       ` Liam Girdwood
2009-01-21 14:44         ` Jonathan Cameron
2009-03-29 19:25           ` Jonathan Cameron
2009-03-30  9:52             ` Mark Brown
2009-03-31 10:55               ` Mark Brown
2009-01-20 20:25       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090120124338.GA31521@sirena.org.uk \
    --to=broonie@sirena.org.uk \
    --cc=jic23@cam.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®