From: Mark Brown <broonie@sirena.org.uk>
To: Jonathan Cameron <Jonathan.Cameron@gmail.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
LKML <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@kernel.org>
Subject: Re: regulator: Add disable_on_boot flag to constraints.
Date: Tue, 20 Jan 2009 20:25:11 +0000 [thread overview]
Message-ID: <20090120202511.GA6864@sirena.org.uk> (raw)
In-Reply-To: <4975CF70.5080802@gmail.com>
On Tue, Jan 20, 2009 at 01:19:44PM +0000, Jonathan Cameron wrote:
> index 3794773..fc0a641 100644
> --- a/include/linux/regulator/machine.h
> +++ b/include/linux/regulator/machine.h
> @@ -112,10 +112,10 @@ struct regulation_constraints {
> suspend_state_t initial_state; /* suspend state to set at init */
>
> /* constriant flags */
> - unsigned always_on:1; /* regulator never off when system is on */
> - unsigned boot_on:1; /* bootloader/firmware enabled regulator */
> - unsigned apply_uV:1; /* apply uV constraint iff min == max */
> + unsigned always_on:1; /* regulator never off when system on */
> + unsigned boot_on:1; /* bootloader/firmware enabled reg */
> + unsigned disable_on_boot:1; /* regulator to be disabled at boot */
> + unsigned apply_uV:1; /* apply uV constraint iff min == max */
> };
This needs kerneldoc adding for the new entry. Other than that
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
prev parent reply other threads:[~2009-01-20 20:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 12:07 regulator: Add always off " Jonathan Cameron
2009-01-20 12:43 ` Mark Brown
2009-01-20 13:00 ` Jonathan Cameron
2009-01-20 13:19 ` regulator: Add disable_on_boot flag " Jonathan Cameron
2009-01-20 20:14 ` Liam Girdwood
2009-01-21 14:44 ` Jonathan Cameron
2009-03-29 19:25 ` Jonathan Cameron
2009-03-30 9:52 ` Mark Brown
2009-03-31 10:55 ` Mark Brown
2009-01-20 20:25 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120202511.GA6864@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=Jonathan.Cameron@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome