* [PATCH] xen: handle highmem pages correctly when shrinking a domain
@ 2009-01-23 16:26 Ian Campbell
2009-01-23 17:56 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Ian Campbell @ 2009-01-23 16:26 UTC (permalink / raw)
To: linux-kernel
Cc: Jeremy Fitzhardinge, Ingo Molnar, dan.magenheimer, Xen-devel,
Stable Kernel
This commit causes a crash if the page being released is a highmem
page.
commit 1058a75f07b9bb8323fb5197be5526220f8b75cf
Author: Dan Magenheimer <dan.magenheimer@oracle.com>
Date: Thu Jan 22 14:36:08 2009 -0800
xen: actually release memory when shrinking domain
If a page is highmem then there is no need to unmap it.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: dan.magenheimer@oracle.com <dan.magenheimer@oracle.com>
Cc: Xen-devel <xen-devel@lists.xensource.com>
Cc: Stable Kernel <stable@kernel.org>
---
drivers/xen/balloon.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff -r 7f26a03c3e02 -r 70c0102ea4c1 drivers/xen/balloon.c
--- a/drivers/xen/balloon.c Fri Jan 23 14:14:59 2009 +0000
+++ b/drivers/xen/balloon.c Fri Jan 23 16:24:09 2009 +0000
@@ -292,10 +292,13 @@
scrub_page(page);
- ret = HYPERVISOR_update_va_mapping(
- (unsigned long)__va(pfn << PAGE_SHIFT),
- __pte_ma(0), 0);
- BUG_ON(ret);
+ if (!PageHighMem(page)) {
+ ret = HYPERVISOR_update_va_mapping(
+ (unsigned long)__va(pfn << PAGE_SHIFT),
+ __pte_ma(0), 0);
+ BUG_ON(ret);
+ }
+
}
/* Ensure that ballooned highmem pages don't have kmaps. */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xen: handle highmem pages correctly when shrinking a domain
2009-01-23 16:26 [PATCH] xen: handle highmem pages correctly when shrinking a domain Ian Campbell
@ 2009-01-23 17:56 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-01-23 17:56 UTC (permalink / raw)
To: Ian Campbell
Cc: linux-kernel, Jeremy Fitzhardinge, dan.magenheimer, Xen-devel,
Stable Kernel
* Ian Campbell <ian.campbell@citrix.com> wrote:
> This commit causes a crash if the page being released is a highmem
> page.
>
> commit 1058a75f07b9bb8323fb5197be5526220f8b75cf
> Author: Dan Magenheimer <dan.magenheimer@oracle.com>
> Date: Thu Jan 22 14:36:08 2009 -0800
>
> xen: actually release memory when shrinking domain
>
> If a page is highmem then there is no need to unmap it.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Jeremy Fitzhardinge <jeremy@goop.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: dan.magenheimer@oracle.com <dan.magenheimer@oracle.com>
> Cc: Xen-devel <xen-devel@lists.xensource.com>
> Cc: Stable Kernel <stable@kernel.org>
> ---
> drivers/xen/balloon.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Applied to tip/x86/urgent, thanks Ian!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-23 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-23 16:26 [PATCH] xen: handle highmem pages correctly when shrinking a domain Ian Campbell
2009-01-23 17:56 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®