* Re: [PATCH] Fix missing ifdef in isdn_ppp
[not found] <20090122221827.GA28623@pingi.kke.suse.de>
@ 2009-01-23 9:44 ` Hannes Eder
2009-01-26 20:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2009-01-23 9:44 UTC (permalink / raw)
To: Karsten Keil
Cc: Daniele Venzano, kernel-janitors, netdev, linux-kernel, David Miller
Add CC. I think this could go upstream via David Miller's net-2.6 tree.
Best,
Hannes
On Thu, Jan 22, 2009 at 11:18 PM, Karsten Keil <kkeil@suse.de> wrote:
> The following patch fixes a warning caused by a missing ifdef in
> isdn_ppp.c. A function was defined, but never used if CONFIG_IPPP_FILTER
> was not defined.
>
> The warning was: 'get_filter' defined but not used
> Patch is against 2.6.28.1
>
> Signed-off-by: Daniele Venzano <venza@brownhat.org>
> Acked-by: Karsten Keil <kkeil@suse.de>
>
> --- a/drivers/isdn/i4l/isdn_ppp.c 2009-01-22 15:01:27.000000000 +0100
> +++ b/drivers/isdn/i4l/isdn_ppp.c 2009-01-22 15:01:59.000000000 +0100
> @@ -431,6 +431,7 @@ set_arg(void __user *b, void *val,int le
> return 0;
> }
>
> +#ifdef CONFIG_IPPP_FILTER
> static int get_filter(void __user *arg, struct sock_filter **p)
> {
> struct sock_fprog uprog;
> @@ -465,6 +466,7 @@ static int get_filter(void __user *arg,
> *p = code;
> return uprog.len;
> }
> +#endif /* CONFIG_IPPP_FILTER */
>
> /*
> * ippp device ioctl
>
^ permalink raw reply [flat|nested] 2+ messages in thread