* [PATCH] e1000: Fix PCI enable to honor the need_ioport flag
@ 2009-02-03 17:52 Karsten Keil
2009-02-03 23:18 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Karsten Keil @ 2009-02-03 17:52 UTC (permalink / raw)
To: linux-kernel; +Cc: Jeff Kirsher, David S. Miller
On machine were no IO ports are assigned the call
to pci_enable_device() will fail, even if need_ioport
is false, we need to use pci_enable_device_mem() here.
Signed-off-by: Karsten Keil <kkeil@suse.de>
---
drivers/net/e1000/e1000_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index c986978..6bd63cc 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -940,7 +940,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
err = pci_enable_device(pdev);
} else {
bars = pci_select_bars(pdev, IORESOURCE_MEM);
- err = pci_enable_device(pdev);
+ err = pci_enable_device_mem(pdev);
}
if (err)
return err;
--
1.5.6.4
--
Karsten Keil
SuSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] e1000: Fix PCI enable to honor the need_ioport flag
2009-02-03 17:52 [PATCH] e1000: Fix PCI enable to honor the need_ioport flag Karsten Keil
@ 2009-02-03 23:18 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-03 23:18 UTC (permalink / raw)
To: kkeil; +Cc: linux-kernel, jeffrey.t.kirsher
From: Karsten Keil <kkeil@suse.de>
Date: Tue, 3 Feb 2009 18:52:17 +0100
> On machine were no IO ports are assigned the call
> to pci_enable_device() will fail, even if need_ioport
> is false, we need to use pci_enable_device_mem() here.
>
> Signed-off-by: Karsten Keil <kkeil@suse.de>
Applied.
Please CC: netdev@vger.kernel.org for networking patches in the future
so that they get properly tracked at:
http://patchwork.ozlabs.org/project/netdev/list/
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-03 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-03 17:52 [PATCH] e1000: Fix PCI enable to honor the need_ioport flag Karsten Keil
2009-02-03 23:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®