[PATCH] x86_64: print DMI info in the oops trace

[PATCH] x86_64: print DMI info in the oops trace

[Kyle McMartin]

From: Kyle McMartin <kyle@redhat.com>

This patch echoes what we already do on 32-bit since
90f7d25c6b672137344f447a30a9159945ffea72, and prints the DMI
product name in show_regs, so that system specific problems can be
easily identified.

Signed-off-by: Kyle McMartin <kyle@redhat.com>
---

Noticed we weren't doing this on x86_64 while backporting this change
to 2.6.27 for Fedora... Any reason for it?

cheers, Kyle

 arch/x86/kernel/process_64.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index 416fb92..85b4cb5 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -40,6 +40,7 @@
 #include <linux/uaccess.h>
 #include <linux/io.h>
 #include <linux/ftrace.h>
+#include <linux/dmi.h>
 
 #include <asm/pgtable.h>
 #include <asm/system.h>
@@ -151,14 +152,18 @@ void __show_regs(struct pt_regs *regs, int all)
 	unsigned long d0, d1, d2, d3, d6, d7;
 	unsigned int fsindex, gsindex;
 	unsigned int ds, cs, es;
+	const char *board;
 
 	printk("\n");
 	print_modules();
-	printk(KERN_INFO "Pid: %d, comm: %.20s %s %s %.*s\n",
+	board = dmi_get_system_info(DMI_PRODUCT_NAME);
+	if (!board)
+		board = "";
+	printk(KERN_INFO "Pid: %d, comm: %.20s %s %s %.*s %s\n",
 		current->pid, current->comm, print_tainted(),
 		init_utsname()->release,
 		(int)strcspn(init_utsname()->version, " "),
-		init_utsname()->version);
+		init_utsname()->version, board);
 	printk(KERN_INFO "RIP: %04lx:[<%016lx>] ", regs->cs & 0xffff, regs->ip);
 	printk_address(regs->ip, 1);
 	printk(KERN_INFO "RSP: %04lx:%016lx  EFLAGS: %08lx\n", regs->ss,
-- 
1.6.0.6

Re: [PATCH] x86_64: print DMI info in the oops trace

[Ingo Molnar]

* Kyle McMartin <kyle@infradead.org> wrote:

> From: Kyle McMartin <kyle@redhat.com>
> 
> This patch echoes what we already do on 32-bit since
> 90f7d25c6b672137344f447a30a9159945ffea72, and prints the DMI
> product name in show_regs, so that system specific problems can be
> easily identified.
> 
> Signed-off-by: Kyle McMartin <kyle@redhat.com>

Applied to tip/x86/urgent, thanks Kyle!

> Noticed we weren't doing this on x86_64 while backporting this change to 
> 2.6.27 for Fedora... Any reason for it?

No reason, simple oversight. Also, a good 75% of the x86 testers are still 
on 32-bit and covering the main volume is what such changes tend to aim for 
primarily. The remaining 25% is nice to have too :)

If you notice such things - or if you have anything in the Fedora srpm that 
you think is worth mainlining, just drop us a patch - it's apprecitated.

	Ingo