From: David Miller <davem@davemloft.net>
To: kamezawa.hiroyu@jp.fujitsu.com
Cc: mel@csn.ul.ie, heiko.carstens@de.ibm.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: HOLES_IN_ZONE...
Date: Thu, 05 Feb 2009 01:21:23 -0800 (PST) [thread overview]
Message-ID: <20090205.012123.141238531.davem@davemloft.net> (raw)
In-Reply-To: <20090205180617.8ee3dfb5.kamezawa.hiroyu@jp.fujitsu.com>
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Date: Thu, 5 Feb 2009 18:06:17 +0900
> @@ -2632,7 +2633,8 @@ void __meminit memmap_init_zone(unsigned
> if (context == MEMMAP_EARLY) {
> if (!early_pfn_valid(pfn))
> continue;
> - if (!early_pfn_in_nid(pfn, nid))
> + tmp = early_pfn_in_nid(pfn, nid);
> + if (tmp > -1 && tmp != nid)
early_pfn_in_nid() returns true or false, not the found nid
I think you meant to change this to call early_pfn_to_nid()
I'll make that correction and test your patch.
BTW, if you make that conversion there is no need for
early_pfn_in_nid() since there will be no other users.
next prev parent reply other threads:[~2009-02-05 9:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 6:26 HOLES_IN_ZONE David Miller
2009-02-05 7:43 ` HOLES_IN_ZONE KAMEZAWA Hiroyuki
2009-02-05 8:00 ` HOLES_IN_ZONE Heiko Carstens
2009-02-05 23:44 ` HOLES_IN_ZONE David Miller
2009-02-06 7:59 ` HOLES_IN_ZONE Heiko Carstens
2009-02-05 9:06 ` HOLES_IN_ZONE KAMEZAWA Hiroyuki
2009-02-05 9:21 ` David Miller [this message]
2009-02-05 9:34 ` HOLES_IN_ZONE KAMEZAWA Hiroyuki
2009-02-05 9:56 ` HOLES_IN_ZONE David Miller
2009-02-05 10:39 ` HOLES_IN_ZONE Mel Gorman
2009-02-05 11:14 ` [BUGFIX][PATCH] fix memmap init to initialize valid memmap for memory hole. (Was HOLES_IN_ZONE KAMEZAWA Hiroyuki
2009-02-05 10:10 ` HOLES_IN_ZONE Mel Gorman
2009-02-05 10:14 ` HOLES_IN_ZONE David Miller
2009-02-05 10:41 ` HOLES_IN_ZONE Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205.012123.141238531.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome