From: David Miller <davem@davemloft.net>
To: mel@csn.ul.ie
Cc: kamezawa.hiroyu@jp.fujitsu.com, heiko.carstens@de.ibm.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: HOLES_IN_ZONE...
Date: Thu, 05 Feb 2009 02:14:29 -0800 (PST) [thread overview]
Message-ID: <20090205.021429.170975463.davem@davemloft.net> (raw)
In-Reply-To: <20090205101023.GD26878@csn.ul.ie>
From: Mel Gorman <mel@csn.ul.ie>
Date: Thu, 5 Feb 2009 10:10:23 +0000
> On Wed, Feb 04, 2009 at 10:26:51PM -0800, David Miller wrote:
> > As a suggestion, it would have been a lot more pleasant if the code
> > validated this requirement (in the !HOLES_IN_ZONE case) at boot time
> > instead of after 2 hours of stress testing :-(
> >
>
> Nice maybe, but we'd take a hit on pfn_valid_within() which goes from
> being compiled-away on architectures that don't need it to being
> a read of a shared cacheline and a branch.
I said at boot time Mel, not in the fast paths. Meaning, we'd
check it after all the available ranges get registered and
tossed into the free page lists.
Anyways, it appears we have a fix already, read the rest of
the thread.
next prev parent reply other threads:[~2009-02-05 10:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 6:26 HOLES_IN_ZONE David Miller
2009-02-05 7:43 ` HOLES_IN_ZONE KAMEZAWA Hiroyuki
2009-02-05 8:00 ` HOLES_IN_ZONE Heiko Carstens
2009-02-05 23:44 ` HOLES_IN_ZONE David Miller
2009-02-06 7:59 ` HOLES_IN_ZONE Heiko Carstens
2009-02-05 9:06 ` HOLES_IN_ZONE KAMEZAWA Hiroyuki
2009-02-05 9:21 ` HOLES_IN_ZONE David Miller
2009-02-05 9:34 ` HOLES_IN_ZONE KAMEZAWA Hiroyuki
2009-02-05 9:56 ` HOLES_IN_ZONE David Miller
2009-02-05 10:39 ` HOLES_IN_ZONE Mel Gorman
2009-02-05 11:14 ` [BUGFIX][PATCH] fix memmap init to initialize valid memmap for memory hole. (Was HOLES_IN_ZONE KAMEZAWA Hiroyuki
2009-02-05 10:10 ` HOLES_IN_ZONE Mel Gorman
2009-02-05 10:14 ` David Miller [this message]
2009-02-05 10:41 ` HOLES_IN_ZONE Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205.021429.170975463.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome