From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Tim Pepper <tpepper@gmail.com>, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: Genapic cleanup & NUMAQ/es7000 removal
Date: Thu, 5 Feb 2009 21:27:30 +0100 [thread overview]
Message-ID: <20090205202730.GJ14832@one.firstfloor.org> (raw)
In-Reply-To: <20090205172941.GA24599@elte.hu>
> I'm not going to apply that series for the reasons i outlined in the NUMAQ
> discussion already. The runtime callbacks arent really a maintenance
> problem: most of them are in boot code so it's not a runtime overhead issue.
Ok. It's basically dead code now, dropping it would just make
the kernels a little smaller and also the code somewhat easier
to read.
If you keep them I would be interested in hearing about your testing plan
for es7000 and NUMAQ AFAIK there is noone currently running them which
makes that likely challenging.
Also the first two patches in the series were independent cleanups
not directly related and should be applied anyways independent
whether unused code should be dropped or not.
commit fa9b9131b555b1d72d6bbfa8c1d6cb22659cc011
Remove empty setup_portio_remap inlines in bigsmp/summit
These are all unused inlines
commit 47e05d047c0e9c5c75003ec7ce97de753b264ed6
Move wakeup_secondary_via_nmi into numaq_32.c
It's only used there.
-Andi
next prev parent reply other threads:[~2009-02-05 20:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 10:17 Andi Kleen
2009-01-30 10:17 ` [PATCH] Move wakeup_secondary_via_nmi into numaq_32.c Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove empty setup_portio_remap inlines in bigsmp/summit Andi Kleen
2009-01-30 10:17 ` [PATCH] Mark NUMAQ broken Andi Kleen
2009-01-30 10:17 ` [PATCH] Mark ES7000 subarch broken Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove store_NMI_vector in genapic Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove smp_callin_clear_local_apic hook Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove multi_timer_check Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove setup_portio_remap Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove wakeup_cpu genapic vector Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove now unused default_update_genapic Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove trampoline_phys_low/high genapic fields Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove enable_apic_mode genapic hook Andi Kleen
2009-01-30 10:17 ` [PATCH] Remove setup_ioapic_ids x86_quirks hook Andi Kleen
2009-02-05 16:15 ` Genapic cleanup & NUMAQ/es7000 removal Tim Pepper
2009-02-05 17:29 ` Ingo Molnar
2009-02-05 20:27 ` Andi Kleen [this message]
2009-02-05 21:25 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205202730.GJ14832@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tpepper@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®